Allow admins to remove CKAN flag#437
Closed
HebaruSan wants to merge 1 commit intoKSP-SpaceDock:alphafrom
Closed
Conversation
Member
|
SpaceDock/KerbalStuff/blueprints/mods.py Lines 302 to 306 in 4dee33b ? |
Member
Author
|
Oh, I forgot that! I thought we had a conversation recently about the need to add this. |
Member
Author
|
Will need to find a new home for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the CKAN badge can't be removed from a mod even if the CKAN team decides not to add it to CKAN. This may confuse users who think it would be there and can't find it, and it also causes some minor unnecessary network traffic from SpaceDock to the CKAN webhooks when the mod is edited or updated.
Changes
Now admin users will see a new X button within the CKAN badge:
When you click it, a confirmation dialog appears:
If you click the Remove CKAN Flag button, then a new
/mod/<mod_id>/unckanroute removes the flag and refreshes the page so you can see the badge is gone.Also the mod page's
div.headerpreviously had abackground: transparent;style which was immediately overridden bybackground-color: #FFFFFF;. In practice all this accomplished was to mess up the layout of the header graphic. This is now removed so the header graphic will appear as it was intended to.