-
Notifications
You must be signed in to change notification settings - Fork 10
Major Update #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Major Update #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except the CKAN ones because those are self-evident
makes debugging way easier in Rider
This means that everything can be set in .csproj.user without hacks
and recommend not using KSPBT_GameRoot in csproj
For building for use in the unity editor, handy for UIs!
All properties and most items are now documented. dependencies page now recommends using `ModReference`
### Msbuild
- Renamed global msbuild properties to have the `KSPBT_` prefix to avoid namespace collisions with other frameworks
- `KSPRoot` is now `KSPBT_GameRoot`. It should no longer be referenced within a .csproj file
- `RepoRootPath` is now `KSPBT_ModRoot`, and should now point to the mod folder within GameData rather than the
root of a git repo
- `BinariesOutputRelativePath` is now `KSPBT_ModPluginFolder`
- `GenerateKSPAssemblyAttribute` is now `KSPBT_GenerateAssemblyAttribute` and defaults to true
- `GenerateKSPAssemblyDependencyAttributes` is now `KSPBT_GenerateDependencyAttributes` and defaults to true
- `ReferenceUnityAssemblies` is now `KSPBT_ReferenceUnityAssemblies`
- `ReferenceKSPAssemblies` is now `KSPBT_ReferenceGameAssemblies`
- Added the `KSPBT_ReferenceSystemAssemblies` property to control referencing the mono system DLLs within the KSP
managed folder. Setting this property to false will load the implicit framework DLLs instead.
- Mod dependencies should now be declared with
`ModReference` items. This avoids the need for the KSP install path to be known at evaluation time.
It is too constraining to support both. At the moment the msbuild side still supports them, but the actions do not. they will not be tested any longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change (so the version would change to 0.1.0 or even 1.0.0).
Docs build for this branch: https://kspbuildtools.readthedocs.io/en/msbuild-refactor/
The goals here were:
Changelog:
KSPBT_prefix to avoid namespace collisions with other frameworksKSPRootis nowKSPBT_GameRoot. It should no longer be referenced within a .csproj fileRepoRootPathis nowKSPBT_ModRoot, and should now point to the mod folder within GameData rather than theroot of a git repo
BinariesOutputRelativePathis nowKSPBT_ModPluginFolderGenerateKSPAssemblyAttributeis nowKSPBT_GenerateAssemblyAttributeand defaults to trueGenerateKSPAssemblyDependencyAttributesis nowKSPBT_GenerateDependencyAttributesand defaults to trueReferenceUnityAssembliesis nowKSPBT_ReferenceUnityAssembliesReferenceKSPAssembliesis nowKSPBT_ReferenceGameAssembliesKSPBT_ReferenceSystemAssembliesproperty to control referencing the mono system DLLs within the KSPmanaged folder. Setting this property to false will load the implicit framework DLLs instead.
ModReferenceitems. This avoids the need for the KSP install path to be known at evaluation time.