-
Notifications
You must be signed in to change notification settings - Fork 10
Re-enable support for packages.config style projects in next
#68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next
JonnyOThan
approved these changes
Oct 29, 2025
Contributor
JonnyOThan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
drewcassidy
added a commit
that referenced
this pull request
Oct 31, 2025
### Msbuild
- Renamed global msbuild properties to have the `KSPBT_` prefix to avoid namespace collisions with other frameworks
- `KSPRoot` is now `KSPBT_GameRoot`. It should no longer be referenced within a .csproj file
- `RepoRootPath` is now `KSPBT_ModRoot`, and should now point to the mod folder within GameData rather than the
root of a git repo
- `BinariesOutputRelativePath` is now `KSPBT_ModPluginFolder`
- `GenerateKSPAssemblyAttribute` is now `KSPBT_GenerateAssemblyAttribute` and defaults to true
- `GenerateKSPAssemblyDependencyAttributes` is now `KSPBT_GenerateDependencyAttributes` and defaults to true
- `ReferenceUnityAssemblies` is now `KSPBT_ReferenceUnityAssemblies`
- `ReferenceKSPAssemblies` is now `KSPBT_ReferenceGameAssemblies`
- Added the `KSPBT_ReferenceSystemAssemblies` property to control referencing the mono system DLLs within the KSP
managed folder. Setting this property to false will load the implicit framework DLLs instead.
- Mod dependencies should now be declared with
`ModReference` items. This avoids the need for the KSP install path to be known at evaluation time.
- Only include Log.cs (or anything else in include/unity) when `KSPBT_ReferenceUnityAssemblies` is `true` (#61)
- Fix `KSP_VERSION_MAX` getting mangled when using an existing version file (#64)
- Fix incorrect behavior when building without a solution (#50)
### Docs
- Fixed git submodule example to work even for tagged releases (#49)
### Actions
- KSPBT actions used in reusable workflows are now pinned with each tag, instead of using actions from `main`. All calls to reusable workflows should be pinned to a tag to ensure the correct actions are being used. (#21)
- `compile` action: Use `dotnet restore` instead of `nuget restore` by default, allowing the action to work on any Ubuntu runner image. Added the `use-nuget-restore` option to restore the previous behavior for projects that use packages.config for dependencies. (#68)
- `compile` action: Removed call to`actions/setup-dotnet`. Setting up .NET should be done as a separate step. (#65)
- `setup-ckan` action: Sped up execution by skipping recommended packages and man-db updates
- `assemble-release` action: `outputs.artifact-path` now includes the `.zip` extension (#51)
drewcassidy
added a commit
that referenced
this pull request
Nov 14, 2025
### Msbuild
- Renamed global msbuild properties to have the `KSPBT_` prefix to avoid namespace collisions with other frameworks
- `KSPRoot` is now `KSPBT_GameRoot`. It should no longer be referenced within a .csproj file
- `RepoRootPath` is now `KSPBT_ModRoot`, and should now point to the mod folder within GameData rather than the
root of a git repo
- `BinariesOutputRelativePath` is now `KSPBT_ModPluginFolder`
- `GenerateKSPAssemblyAttribute` is now `KSPBT_GenerateAssemblyAttribute` and defaults to true
- `GenerateKSPAssemblyDependencyAttributes` is now `KSPBT_GenerateDependencyAttributes` and defaults to true
- `ReferenceUnityAssemblies` is now `KSPBT_ReferenceUnityAssemblies`
- `ReferenceKSPAssemblies` is now `KSPBT_ReferenceGameAssemblies`
- Added the `KSPBT_ReferenceSystemAssemblies` property to control referencing the mono system DLLs within the KSP
managed folder. Setting this property to false will load the implicit framework DLLs instead.
- Mod dependencies should now be declared with
`ModReference` items. This avoids the need for the KSP install path to be known at evaluation time.
- Only include Log.cs (or anything else in include/unity) when `KSPBT_ReferenceUnityAssemblies` is `true` (#61)
- Fix `KSP_VERSION_MAX` getting mangled when using an existing version file (#64)
- Fix incorrect behavior when building without a solution (#50)
### Actions
- KSPBT actions used in reusable workflows are now pinned with each tag, instead of using actions from `main`. All calls to reusable workflows should be pinned to a tag to ensure the correct actions are being used. (#21)
- `compile` action: Use `dotnet restore` instead of `nuget restore` by default, allowing the action to work on any Ubuntu runner image. Added the `use-nuget-restore` option to restore the previous behavior for projects that use packages.config for dependencies. (#68)
- `compile` action: Removed call to`actions/setup-dotnet`. Setting up .NET should be done as a separate step. (#65)
- `setup-ckan` action: Sped up execution by skipping recommended packages and man-db updates
- `setup-ckan` action: Add `ckan-install-method` option for installation method. Currently supports `'apt'` for installation on Debian/Ubuntu, or `'skip'` to skip installation for runners that already have CKAN installed.
- `assemble-release` action: `outputs.artifact-path` now includes the `.zip` extension (#51)
Merged
drewcassidy
added a commit
that referenced
this pull request
Nov 20, 2025
### Msbuild
- Renamed global msbuild properties to have the `KSPBT_` prefix to avoid namespace collisions with other frameworks
- `KSPRoot` is now `KSPBT_GameRoot`. It should no longer be referenced within a .csproj file
- `RepoRootPath` is now `KSPBT_ModRoot`, and should now point to the mod folder within GameData rather than the
root of a git repo
- `BinariesOutputRelativePath` is now `KSPBT_ModPluginFolder`
- `GenerateKSPAssemblyAttribute` is now `KSPBT_GenerateAssemblyAttribute` and defaults to true
- `GenerateKSPAssemblyDependencyAttributes` is now `KSPBT_GenerateDependencyAttributes` and defaults to true
- `ReferenceUnityAssemblies` is now `KSPBT_ReferenceUnityAssemblies`
- `ReferenceKSPAssemblies` is now `KSPBT_ReferenceGameAssemblies`
- Added the `KSPBT_ReferenceSystemAssemblies` property to control referencing the mono system DLLs within the KSP
managed folder. Setting this property to false will load the implicit framework DLLs instead.
- Mod dependencies should now be declared with
`ModReference` items. This avoids the need for the KSP install path to be known at evaluation time.
- Fix `KSP_VERSION_MAX` getting mangled when using an existing version file (#64)
- Fix incorrect behavior when building without a solution (#50)
### Actions
- KSPBT actions used in reusable workflows are now pinned with each tag, instead of using actions from `main`. All calls to reusable workflows should be pinned to a tag to ensure the correct actions are being used. (#21)
- `compile` action: Use `dotnet restore` instead of `nuget restore` by default, allowing the action to work on any Ubuntu runner image. Added the `use-nuget-restore` option to restore the previous behavior for projects that use packages.config for dependencies. (#68)
- `compile` action: Removed call to`actions/setup-dotnet`. Setting up .NET should be done as a separate step. (#65)
- `setup-ckan` action: Sped up execution by skipping recommended packages and man-db updates
- `setup-ckan` action: Add `ckan-install-method` option for installation method. Currently supports `'apt'` for installation on Debian/Ubuntu, or `'skip'` to skip installation for runners that already have CKAN installed.
- `assemble-release` action: `outputs.artifact-path` was split into `outputs.artifact-zip-path` and `outputs.artifact-dir-path` containing paths to a zip file and directory respectively. These are also now located under `$RELEASE_STAGING` instead of inside the workspace
- `assemble-release` action: Removed call to `actions/upload-artifact`. This should be done as a separate step.
### Library
- Removed Log.cs and the entire includes directory. Please use [KSPCommunityLib](https://git.offworldcolonies.nexus/KSPModdingLibs/KSPCommunityLib) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires setting the
use-nuget-restoreoption on the compile action/build workflow.Option name might be confusing, since technically it always uses Nuget-the-service, just not Nuget-the-binary. Maybe just "legacy" but Microsoft themselves don't seem to use that terminology.