perf: Optimize MonoUtilities.RefreshContextWindows
#338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This calls
UnityEngine.Object.GetObjectsOfTypewhich is terribly slow. It is not used anywhere in stock which is probably why it hasn't been patched yet. However, several mods do make use of it.On my KSP instance this saves > 1s on every scene switch across a few different mods.
The improvement here is to maintain our own list of active
UIPartActionWindowinstances and use that list instead of callingGetObjectsOfType. It proactively removes all dead instances when one is deleted. Any change that results inUIPartActionWindow.OnDestroynot being called will result in a memory leak anyways so I suspect this is a non-issue.