Module auto cut drogue performance #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved performance of ModuleAutoCutDrogue by harmony patching events to fire when the chutes deploy instead of polling every frame.
- Moved if statement for checking if drogue cutting has already happened this frame, would prevent setting triggered to true previously.
- Actually check if auto cutting drogues is enabled & rearange if statement to check the simple booleans first.
- Updated workflow files to set `use-ckan` to true to install the harmony dependency.
SofieBrink
force-pushed
the
ModuleAutoCutDrogue_Performance
branch
from
366bdc6 to
926b59a
Compare
- Reversed if in repack chute event so simple boolean gets evaluated first, might save a tiny amount of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9