V0.3.0 #19
Merged
V0.3.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed harmony patch for ModuleAutoCutDrogue from the module's cs file and moved it to its own harmony patches folder
- Added ModuleCenterFollowTransform to replace ModuleCoPFollowTransform. - Deprecated ModuleCoPFollowTransform.
- Support mixing and matching what center follows the transform using B9PS
SofieBrink
added
enhancement
|
Would appreciate if you had a look at this one @JonnyOThan, you had some great feedback on the previous version of this module which was very welcome. |
SofieBrink
commented
Nov 17, 2024
| if (enableCoL) part.CoLOffset = part.partInfo.partPrefab.CoLOffset; | ||
| } | ||
| // Set offets back to the values in the prefab if the mode is disabled after initial initialisation; e.g. B9PS | ||
| if (!enableCoP && wasEnabledCoP) part.CoPOffset = part.partInfo.partPrefab.CoPOffset; |
There was a problem hiding this comment.
I'm debating if this should only be done here or in fixed-update too.
Doing it here is probably better for performance, while doing it in fixed-update would mean if something other than B9PS manipulates the KSPFields without calling OnLoad the module would reset the now no longer updating center too.
|
I need this merged sooner rather than later, so i'm just going to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15