Skip to content

Update ModuleCoPFollowTransform #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Update ModuleCoPFollowTransform #7

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b354c19
Update ModuleCoPFollowTransform
SofieBrink Oct 9, 2024
07ad189
small tweaks
JonnyOThan Oct 9, 2024
42bc27d
include part name in debug log
JonnyOThan Oct 9, 2024
4157210
use prefab CoPOffset instead
JonnyOThan Oct 10, 2024
c47d501
serves me right for writing code on github
JonnyOThan Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Source/Modules/ModuleCoPFollowTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,23 @@ public class ModuleCoPFollowTransform : PartModule
[KSPField]
public string transformName;

[SerializeField]
private Transform followTransform;

public override void OnLoad(ConfigNode node)
{
base.OnLoad(node);
if (HighLogic.LoadedScene != GameScenes.LOADING)
if (followTransform == null || followTransform.name != transformName)
{
if (transformName != null) followTransform = part.FindModelTransform(transformName);
if (followTransform == null) Debug.LogError($"[{MODULENAME}] transformName was empty or does not exist.");
Copy link
Contributor

@JonnyOThan JonnyOThan Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be a good idea to include the transform name that was searched for in the error message.

Oh, right, I can just do that.

this.isEnabled = followTransform != null;
this.enabled = followTransform != null;
}
}

public void FixedUpdate()
{
if (!HighLogic.LoadedSceneIsFlight) return;
if (followTransform != null) part.CoPOffset = part.transform.InverseTransformPoint(followTransform.position);
}
}
Expand Down