Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds type aliases for the simple_curly_braces shorthand to improve developer experience by providing clearer type signatures. The module is also made public to allow users to access all the helper types.
- Introduces several type aliases (
SimpleCurlyBraces,LazilyParsed,EagerlyParsed, etc.) for complex return types - Makes the
simple_curly_bracesmodule public while selectively re-exporting only the main items at the crate root - Updates documentation links to properly reference the module vs the function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shorthands/simple_curly_braces.rs | Adds comprehensive type aliases for return types and error types, with proper documentation and test coverage |
| src/shorthands.rs | Changes module visibility to public and updates re-exports to include only primary items |
| src/lib.rs | Updates documentation links to use mod@simple_curly_braces for module references |
| src/enclosed/parser.rs | Updates documentation link to reference the simple_curly_braces function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.