Exam-Problem #857
Exam-Problem #857
Conversation
Removed Exam 1 from the select dropdown. Added a header on the exam problems page to show which exam the problems belong to..
| setProblemIdx(initialProblemIdx); | ||
| } | ||
| }, [initialProblemIdx]); | ||
|
|
There was a problem hiding this comment.
useEffects repeating for same task, use only one
| <Box sx={{ display: 'flex', justifyContent: 'space-between', width: '100%' }}> | ||
| <span>{t[type]}</span> | ||
| <Typography variant="caption" color="text.secondary"> | ||
| ({examcount}) |
There was a problem hiding this comment.
rename this variable , very confusing for quiz, homework and uncategorized problems count
| {/* TODO ALEA4-P3 solutions?.length > 0 && ( | ||
| <Button variant="contained" onClick={() => setShowSolution(!showSolution)}> | ||
| {showSolution ? t.hideSolution : t.showSolution} | ||
| </Button> | ||
| )}*/} | ||
| {showSolution && ( | ||
| <Box mb="10px"> | ||
| {/* solutions.map((solution) => ( | ||
| <div style={{ color: '#555' }} dangerouslySetInnerHTML={{__html:solution}}></div> | ||
| ))*/} | ||
| </Box> | ||
| )} |
There was a problem hiding this comment.
donot remove comment at this place, this was supposed to be work in future TODO ALEA4-P3, put back all comments which are intentionally placed
| }) | ||
| } | ||
| /> | ||
| {/* TODO ALEA4-P3 |
| return [...knownOrder, ...rest]; | ||
| return ['syllabus', 'adventurous'].filter((cat) => categoryMap[cat]?.length); |
There was a problem hiding this comment.
other categories apart from syllabus and adventurous are being ignored completely, look again
| .filter((p) => p.examRefs?.some((e) => isValidExamRef(e.examUri))) | ||
| .map((p) => p.problemId), | ||
| [problems] | ||
| ); |
There was a problem hiding this comment.
do format , readability issue
| } | ||
|
|
||
| const problemUri = problemUris[problemIdx]; | ||
| // TODO ALEA4-P3 const response = responses[problemIdx]; |
| if (!problemUris.length) { | ||
| return ( | ||
| <Typography sx={{ mt: 2 }} color="text.secondary"> | ||
| No problems found for this filter. | ||
| </Typography> | ||
| ); | ||
| } |
There was a problem hiding this comment.
using same thing at line 398, do consider different cases before early returning , as i can interpret earlier no problems found... was shown only in certain condition when tabIndex!=forme and !problemUris.length.
Do check again.
| filtered.forEach((u) => { | ||
| console.log(u, getProblemType(u)); // | ||
| }); | ||
| let finalUris = filtered; | ||
|
|
||
| if (type === 'exam') { | ||
| finalUris = examProblemIds; | ||
| } | ||
|
|
||
| setProblemUris(finalUris); | ||
| setAllProblemUris(finalUris); | ||
| setIsSubmitted(finalUris.map(() => false)); | ||
| setResponses(finalUris.map(() => undefined)); | ||
| setProblemIdx(0); |
There was a problem hiding this comment.
do consider moving onApply functionality to a separate function
|
|
||
| {currentProblem?.examRefs | ||
| ?.filter((exam) => isValidExamRef(exam.examUri)) | ||
| .slice(0, 1) |
There was a problem hiding this comment.
only first value is shown in exam chip, do talk with requirements manager to know exactly which exam to show if any problem is being asked in multiple exam.
| const cleanedD = dParam.replace(/-/g, ' ').replace(/\b\w/g, (c) => c.toUpperCase()); | ||
| const examLabel = exam.term ? `${exam.term} ${cleanedD}`.trim() : cleanedD; |
There was a problem hiding this comment.
use formatExamLabel function defined in exam-problems.tsx here as well
| return result; | ||
| } | ||
|
|
||
| export const formatExamLabel = (examUri?: string, exam?: { number?: string; term?: string }) => { |
There was a problem hiding this comment.
why is there need of passing other param exam object, nowhere it is being used while calling formatExamLabel .Also number and term both can be derived from examUri only
There was a problem hiding this comment.
need to discuss....
Removed Exam 1 from the select dropdown.
Fixed exam problems in the filter view.
Added a header on the exam problems page to show which exam the problems belong to..