Only increment timer and record replays if movement processing happens, fix abuse with zones and low fps/high packet loss#371
Open
zer0k-z wants to merge 5 commits intoKZGlobalTeam:devfrom
Open
Conversation
…s, fix abuse with zones and low fps
zealain
approved these changes
Feb 28, 2023
Collaborator
zealain
left a comment
There was a problem hiding this comment.
Waiting for @GameChaos to port this to KZTimer before I merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first issue is an unique problem with KZ. Timer is incremented upon every
OnPlayerRunCmdPostcall instead of PostThink like bhop/surf does, even if the command is completely disregarded by the server. This means the timer can get wrongfully incremented like this example: https://youtu.be/hVqcXVs3Ug0The replay change is to accommodate this timer change.
The second issue involves the player starting their timer very far away from the start zone trigger. This happens because the function responsible for leaving triggers,
EntityUntouch, is only called at the end of server frame instead of onPostThink. When multiple client packets are processed at once (due to lag/low fps), the trigger'sEndTouchoutput is called too late. I ported EndTouchFix to GOKZ in order to prevent this from happening. This fix should also prevent player from being able to start the timer after teleporting out of start zone.This means a few courses (probably only bonuses) need wiping (at least from the top times), since it will contain times that are no longer possible to obtain.
The current list is as follows: