Merged
Conversation
- Added `MarketDetailScreenTest` and `MarketListScreenTest` using Robolectric and Compose Test library. - Updated `MarketDetailScreen` visibility to `internal` to allow testing. - Integrated Robolectric, JUnit Vintage, and Compose UI test dependencies in `libs.versions.toml` and relevant build files. - Added Robolectric and Kotest extensions to the core test module.
- Removed `kotestExtensionsRobolectric` version and library definition from `gradle/libs.versions.toml`. - Removed `kotest-extensions-robolectric` from `core/test/build.gradle.kts`.
- Add a test to confirm the favorited icon is displayed when the market item is marked as a favorite. - Set the content description on the `FavoriteIcon` to distinguish between favorited and not-favorited states, improving testability and accessibility.
Generated by 🚫 Danger Kotlin against 514f211 |
The `robolectric` dependency is no longer needed in the `core/test` module and has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #313 and #314