Fix issue with green tint in Merrill images#120
Fix issue with green tint in Merrill images#120Alex-Vasile wants to merge 1 commit intoKalpanika:masterfrom
Conversation
|
Thanks so much for this work! Would we expect the test image(s) to change as a result of this addition? If so, can you please also make a PR against x3f_test_images with the new image(s) converted with this fix? That way, we can make sure |
|
(as a side note, this is obviously an argument for a monorepo reorganization, but as you can see, we haven't really been active in this project for 6 years) |
I have tested visually:
|
… is not really shielded and can't be used for calculating the black level
21577cc to
1880430
Compare
Is this something you are still interested in supporting? |
The right "shielded" area is not really shielded and can't be used for calculating the black level. Removing this area completely fixes the green tint in the shadows. Closes #117.
Below is a screenshot of the shielded area from the _SDI8040.X3F from x3f_test_files while is a DP2M file. I'm showing the green channel as shown by RawDigger, the red and blue channel are similar (except the red is much noisier and the blue much less noisy).

(As an aside, that region is very conspicuous with its linear increasing exposure may be used for something).