-
Notifications
You must be signed in to change notification settings - Fork 90
CI: Add build-tests for various compilers on Windows and Ubuntu #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarijnS95
wants to merge
3
commits into
KarypisLab:master
Choose a base branch
from
MarijnS95:build-test-in-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| on: | ||
| - push | ||
|
|
||
| jobs: | ||
| build-linux: | ||
| name: Use clang and gcc via "Unix Makefiles" | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| compiler: [clang, gcc] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: | | ||
| cmake -Bbuild -DCMAKE_C_COMPILER=${{ matrix.compiler }} | ||
| cmake --build build | ||
|
|
||
| build-windows-ninja: | ||
| name: Use clang and clang-cl via Ninja | ||
| runs-on: windows-latest | ||
| strategy: | ||
| matrix: | ||
| # On Windows, clang only enables the WIN32 flag in CMake whereas | ||
| # clang-cl also enables MSVC, because it has a cl.exe-like interface. | ||
| compiler: [clang, clang-cl] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: | | ||
| # Use Ninja because the MSBuild toolchain can only configure | ||
| # alternative compilers via "toolsets", where only ClangCL is | ||
| # supported. | ||
| cmake -Bbuild -GNinja -DCMAKE_C_COMPILER=${{ matrix.compiler }} | ||
| cmake --build build | ||
|
|
||
| build-windows-msbuild: | ||
| name: Use MSVC and clang-cl via MSBuild | ||
| runs-on: windows-latest | ||
| strategy: | ||
| matrix: | ||
| toolset: | ||
| # The default toolset should be the latest 'v143' when nothing is specified | ||
| - | ||
| - -TClangCL | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: | | ||
| cmake -Bbuild ${{ matrix.toolset }} | ||
| cmake --build build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this file because it's no longer being included since b8b8bdc#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL9.
Maybe that's an error though...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my own testing, when adding #45 on top things now fail with
ssize_tbeing missing: https://github.com/MarijnS95/GKlib/actions/runs/16099153358/job/45425988032I assume because the compiler only defines
_WIN32, whereas this now-unusedGKlibSystem.cmakefile used to setWIN32. But only forif(MSVC)of course, socl.exe+clang-clget it butclangwould have missed out too.EDIT: Same for the missing
strerror_r, which is in the#elsefor#if defined(WIN32).