[KAT-1726] Consolidate RDG inspection routines into one place#557
Draft
GioLomia wants to merge 1 commit intoKatanaGraph:masterfrom
Draft
[KAT-1726] Consolidate RDG inspection routines into one place#557GioLomia wants to merge 1 commit intoKatanaGraph:masterfrom
GioLomia wants to merge 1 commit intoKatanaGraph:masterfrom
Conversation
GioLomia
force-pushed
the
consolidate-rdg-inspection
branch
from
287e08a to
98b8c4e
Compare
Contributor
amberhassaan
left a comment
amberhassaan
left a comment
There was a problem hiding this comment.
Initial comments. Will take a more detailed look later.
|
|
||
| void | ||
| doSummary(Graph& graph) { | ||
| std::cout << "NumNodes: " << graph.size() << "\n"; |
Contributor
There was a problem hiding this comment.
use fmt::print everywhere and don't use std::cout and don't #include <iostream>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality for inspecting an RDG is scattered throughout the codebase.
There are
We also have import/conversion executables under
Leaving aside the import/conversion executables for now, there really should be one place for all RDG inspection and manipulation routines (ls, copy, du, etc.).
The core logic should be written in one place (e.g., libtsuba) and then exposed either as an executable or via python bindings (probably both).