Replace Property's value appending with empty value appending#856
Draft
nicelhc13 wants to merge 1 commit intoKatanaGraph:masterfrom
Draft
Replace Property's value appending with empty value appending#856nicelhc13 wants to merge 1 commit intoKatanaGraph:masterfrom
nicelhc13 wants to merge 1 commit intoKatanaGraph:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft updates two parts of Property struct.
The first one is to replace
AppendValues()withAppendEmptyValues().In the past, the former appends dummy vector of size
num_rows. The current Arrow version has much proper API,AppendEmptyValues().The second one is to call
Reserve()before appending empty values to avoid over memory allocations.AppendEmptyValues() allocates about 2x more memory than users passed for optimizations to avoid frequent reallocations.
But this caused out-of-memory when we tested louvain on big graphs like clueweb12.
@roshandathathri I need above updates but I am not sure if it is the best design option.
Could you please assign reviewers who are experts and give any suggestions?