Secret and sample are not groups #481
Merged
+32
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairez
suggested changes
Sep 2, 2025
Comment on lines
1362
to
1370
| The dependent group will only be run if the group being depended on receives an accepted verdict for all test cases in the group. | ||
| If the dependent group is not run, the group score is 0. | ||
|
|
||
| The paths of these required groups, relative to the `data` folder, are listed under the `require_pass` key. |
There was a problem hiding this comment.
Technically, since secret and sample is not a "group", nothing has been stated for secret and sample. However, it will be replaced with something else in a future PR #487.
There was a problem hiding this comment.
Very good points. We'll fix it in #487 as you say...
hairez
approved these changes
Sep 2, 2025
hairez
approved these changes
Sep 2, 2025
Co-authored-by: Harry Zhang <[email protected]>
Co-authored-by: Harry Zhang <[email protected]>
Co-authored-by: Harry Zhang <[email protected]>
niemela
force-pushed
the
clarify-groups
branch
from
4ff6ffe to
7c4ebb7
Compare
hairez
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465.