Clarify dependent groups #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairez
suggested changes
Sep 2, 2025
|
@niemela Please resolve conflict before continuing. I would like to request more changes, but I believe they’re already addressed in commits that haven't been resolved yet. |
Co-authored-by: Harry Zhang <[email protected]>
Co-authored-by: Harry Zhang <[email protected]>
niemela
commented
Sep 3, 2025
Matistjati
reviewed
Sep 3, 2025
Co-authored-by: Joshua Bergman Andersson <[email protected]>
Matistjati
reviewed
Sep 3, 2025
hairez
suggested changes
Sep 3, 2025
Co-authored-by: Joshua Bergman Andersson <[email protected]>
Co-authored-by: Harry Zhang <[email protected]>
hairez
approved these changes
Sep 3, 2025
Matistjati
approved these changes
Sep 3, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463