-
Notifications
You must be signed in to change notification settings - Fork 41
Renovation of the TestCase generation #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
87f9f32 to
25a0200
Compare
7abaaf2 to
ddab633
Compare
|
2cedebc to
21573b2
Compare
64bb3c5 to
82a27ce
Compare
|
@unp1 @mattulbrich Whoever has more experience with the hell of testgen. |
|
addition
same for using the shadowJar very brief window shown and it terminates then with SLF4J(W): Class path contains multiple SLF4J providers. |
unp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the PR once the problem with starting the version is resolved and I tested it on some small examples. Thanks a lot for the work.
key.core.testgen/src/main/java/de/uka/ilkd/key/testgen/ReflectionClassCreator.java
Show resolved
Hide resolved
I have not updated to the recent main. There, it should be fixed by #3639 which was introduced by Isabelle deps. I check it after rebase. UPDATE: Not appeared after rebase. |
4370fdf to
6028a2e
Compare
Starting is resolved: Calling For fostering the command line, the exit code is a good indicator of failure. We should reconsider the |
6028a2e to
7a6e727
Compare
|
Thanks. I will complete the review later today |
|
Worked on CMdLine and I could now also find the directory. It was in my home directory (so it seems the GUI info is ignored?) Maybe we should place it in the directory where it is called by default? Anyways, I think the issues were present before and now at least the generation can be demoed an dI'll approve the change. But please check if the mentioned issues should be dhave been resolved or if they fall under known issues. Thanks! |
unp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Makes it demoable but see my previous comment about known issues
The test case from the book is here: I tried to get binary search working, but was not so successful. |
I avoided to go into the GUI at all. My user story would rather be the generation from inside of the project management / command line. Clear is Objenesis and JML are resolved using Maven Central via pom.xml/build.xml/build.gradle. I am also not sure, how the user story should be for the UI. Because, after the generation you need to leave KeY and go to the terminal. |
c399891 to
b38ac7d
Compare
# Conflicts: # key.core.testgen/src/main/java/de/uka/ilkd/key/testgen/TestCaseGenerator.java # key.core.testgen/src/test/java/de/uka/ilkd/key/testcase/smt/ce/TestCE.java
b38ac7d to
c861b45
Compare
|
Rebased for better history. GUI issues are tracked in #3665 |




Intended Change
Make test case generation usable again, especially from the CLI in the new verification template.
The test case generation was not used for a long time. It was buggy and unstable, and could only be controlled by the UI. This PR tries to revive it a little bit:
Changes
The new layout uses the Maven folder layout, and provides a
build.gradle.ktsand apom.xmlfor building and testingjavapoet. Nobody understands pages ofStringBuilderfoo.picoclifor the Command Line interface, also for the existing interfaces in key.ui, keyext.proofmanagement, ...This is rather an MVP, more options and features can be thought of but first get it running.
Type of pull request