Cleanup: Use Standard Tech for Test Fixtures#3551
Conversation
|
Unfortunately, this PR does not follow the PR summary template of the project. Can you please provide the information of the template? |
|
Thanks for replacing the parser. Actually, I think it is more understanable and clearer with the test cases in individual files. Can that be arranged? |
d21e198 to
23a566f
Compare
done |
23a566f to
334dead
Compare
thanks. Is it on purpose that the files are in a different directory now? |
d883e5e to
1227678
Compare
Avoidance of one more folder level in the hierarchy. It seemed to be unnecessary for script fixtures. |
1227678 to
a91c56f
Compare
|
I have little experience with yml, and, hence, it seems to me that this change actually adds complexity rather than reducing it. I cannot appreciate the improvements that this PR bring. Perhaps someone more familiar w/ the language can see this and do the review. |
5532bd2 to
eaa98f8
Compare
|
Yaml is a pretty common format. I like this change; tests are more compact and readable. |
40576de to
83546ca
Compare
10fcb19 to
db78a20
Compare
db78a20 to
24bed52
Compare
21100bc to
64f902c
Compare
64f902c to
82b2cc9
Compare
This PR removes the
LineProperties.javain favor of YAML test fixture.Pros:
YamlSourcein parameterized testThis PR brings two dependencies for tests: