Use a custom Github action for setting up the SMT solvers#3569
Conversation
5d728da to
785c4db
Compare
a626457 to
433a0cb
Compare
|
Strange: Unit tests succeed on windows, but not on Linux. Error on Linux is:
This happens after 25 min. The Windows run needs 45 min. to complete. @WolframPfeifer @mattulbrich We might hit a memory boundary limit here. Do we have experience with z3 4.14 and cvc5 1.2.1? I would remove the later one from the pipeline for testing. |
fee0fc9 to
c1ca980
Compare
* add a canary to test the availability of SMT solvers
c1ca980 to
6da0f62
Compare
|
From KaKeY:
Issues: #3575 |
6da0f62 to
86064c7
Compare
|
We agreed to keep the two cases with shorter timeout. Since the timeout can unfortunately not be set individually for test cases but is driven by a special settings class, the overhead is not worth it and we keep them deactivated. |
|
@mattulbrich @WolframPfeifer waiting for review ... |
mattulbrich
left a comment
There was a problem hiding this comment.
Please check the version there, add a comment if appropriate or change the line.
Intended Change
Exchange of the
dlsmt.shscripts in favor of a real Github action that uses Github's API for setting up the SMT solvers.This action is self-written and available here: https://github.com/KeYProject/setup-smt
Benefit: The pipeline becomes OS-independent and now we can run macOS and windows pipelines with SMT solvers. This PR also enables SMT solvers on windows unit-test pipelines!
On the road: Fixes for double artifact names on 8our broad release tests](https://github.com/KeYProject/key/actions/workflows/tests_winmac.yml).
Type of pull request
board release tests needs to be triggered manually
broad release test is currently broken as it uses
--release 21on a JRE 17.Ensuring quality
I currently have only added z3 and CVC5 to
setup-smtas these were also indlsmt.sh. Looking atjava-smt3the following exists:Please add a PR at keyproject/setup-smt if some of these are required.