fixing lexing to support static invariants#3583
Merged
Conversation
wadoon
approved these changes
Mar 14, 2025
Member
|
I am not really a fan of the constructs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
This pull request includes a change to the
IMPLICIT_IDENTrule in theKeYLexer.g4file to allow an optional dollar sign before the letter sequence.Lexer rule modification:
key.core/src/main/antlr4/KeYLexer.g4: Modified theIMPLICIT_IDENTrule to accept an optional dollar sign ('<) before the letter sequence.The reason is that static invariants are represented as
Classname::<$inv>which one was not able to use in a manual cut.But valid key terms should be parseable.
Plan
It is only a 4 character fix allowing implicit identifiers to start with a
$.Type of pull request
Ensuring quality
n/a
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.