Skip to content

Fix proof task tree forced white background.#3663

Merged
Drodt merged 1 commit intomainfrom
weigl/fixprooftasktree
Nov 21, 2025
Merged

Fix proof task tree forced white background.#3663
Drodt merged 1 commit intomainfrom
weigl/fixprooftasktree

Conversation

@wadoon
Copy link
Member

@wadoon wadoon commented Sep 20, 2025

Related Issue and Solution

The proof task tree (left upper component in the UI) has a forced white background if it is empty initially. This does not respect LaFs.

To be more precise, the logic was as follows:

  1. The scroll pane was empty initally (view port not set)
  2. The default view port was requested and the background was set to white.
  3. If finally a proof was loaded, the view port was set to the appropriate JList.

New logic:

  1. Just set the JList directly.

The rest is clean-up of unused methods.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)

  • There are changes to the (Java) code

Ensuring quality

  • Visual inspection in Dark Theme and Metal. Not coverable by automatic tests.

@wadoon wadoon requested a review from unp1 September 20, 2025 22:58
@wadoon wadoon self-assigned this Sep 20, 2025
@wadoon wadoon added this to the v2.12.4 milestone Sep 20, 2025
@wadoon wadoon force-pushed the weigl/fixprooftasktree branch from 00b49b2 to 016d68c Compare November 20, 2025 16:01
@Drodt Drodt self-requested a review November 21, 2025 13:45
@Drodt Drodt enabled auto-merge November 21, 2025 13:50
@Drodt Drodt added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 7750e75 Nov 21, 2025
35 checks passed
@Drodt Drodt deleted the weigl/fixprooftasktree branch November 21, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants