JavaRedux: Integer methods + List::remove + NoSuchElementException#3719
Open
FliegendeWurst wants to merge 3 commits intoKeYProject:mainfrom
Open
JavaRedux: Integer methods + List::remove + NoSuchElementException#3719FliegendeWurst wants to merge 3 commits intoKeYProject:mainfrom
FliegendeWurst wants to merge 3 commits intoKeYProject:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
============================================
- Coverage 47.99% 47.98% -0.01%
- Complexity 16046 16059 +13
============================================
Files 1683 1683
Lines 96044 96094 +50
Branches 15387 15394 +7
============================================
+ Hits 46093 46114 +21
- Misses 44681 44713 +32
+ Partials 5270 5267 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I would like to add a test that checks the below is provable, how would I go about that? /*@ public normal_behavior
@ ensures \result;
@ assignable \nothing;
@*/
static boolean testRemove() {
List list = new ArrayList();
list.add("a");
list.add("b");
list.add("c");
Object removed = list.remove(0);
return removed == "a" && list.get(0) == "b" && list.get(1) == "c";
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
The
Integerclass is a bit useless without providing at leastvalueOfandintValue, so I added specifications for those methods. And the fieldvalueto store the int value.The
List::removemethod to remove elements by index is useful to have.The
NoSuchElementExceptionclass is required to implement iterators.Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.