Conversation
Member
Author
|
Open questions for this PR:
|
Member
|
I have tested this change a bit and it seems to work well. 👍 |
WolframPfeifer
approved these changes
Feb 5, 2026
Member
WolframPfeifer
left a comment
There was a problem hiding this comment.
Thanks, this indeed solves the problem also in the case study where it occurred.
For your questions:
- Since the other tests also seem to read from that folder, I think we can keep it like that for now.
- Since both loop rules use the same function here, I think it is not beneficial to have a second test. It might, however, be a good idea to do a more fine-grained test which only tests the method in MiscTools without loading the taclets, create the environment etc. (i.e. a proper unit test).
Member
|
@Drodt I approved, but maybe you can check my comment regarding the unit test and merge depending on your opinion ... |
Member
Author
Good idea; I'll look into it next week (hopefully) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3720.
Intended Change
(Ghost) set statements are now considered for the set of to-be-anonymized variables for loop scope rules.
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.