Conversation
|
Thanks for the great pull, and I really appreciate it. Can you squash the commits to be more concise? |
|
You want me to make that one big commit? My strategy is to make them small as you maybe want skip some of them (as I did, cause not generic enough). |
|
All you have made are awesome. I cannot find any commit to skip. ^_^ I'm recently try to refactoring it, your commits help this a lot.
|
|
@waja I checked the pull request this morning and found yours lie here because of the conflicts. Is this OK for you because these great work belongs to you and somehow I stolen it? Ken |
I started to make some changes to the code to make it more comfortable for me, maybe you can reuse it.