Fix onPlayBackStarted event #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good evening! I have been using your add on would really appreciate this fix being but into the main Kodi repo. For now I have made manual changes on my local copy. Not sure how the PR process works here but figured this may be a good place to leave a message :) Have a great weekend. Cheers, |
|
@mcowell can you gimme some hints how to perform the change on Android TV version of Kodi ? many thanks |
pikim
added a commit
to pikim/script.service.kodi.callbacks
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks to #6 (comment) I fixed the
onPlayBackStartedevent, replacing it withonAVStarted.I didn't changed the user
on playback startedmessage because I think this is easier to understand but it might be confusing with the Kodi API so maybe I should add an event instead of replacing the old one.Let me know.
Have a nice day.