Skip to content

Add Takumi Guard setup step to build workflow#755

Merged
KengoTODA merged 1 commit intomasterfrom
KengoTODA-patch-1
Mar 25, 2026
Merged

Add Takumi Guard setup step to build workflow#755
KengoTODA merged 1 commit intomasterfrom
KengoTODA-patch-1

Conversation

@KengoTODA
Copy link
Copy Markdown
Owner

No description provided.

@KengoTODA KengoTODA self-assigned this Mar 25, 2026
Copilot AI review requested due to automatic review settings March 25, 2026 06:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Takumi Guard initialization to the CI build workflow to enable npm-related protection/validation during the build pipeline.

Changes:

  • Inserted flatt-security/setup-takumi-guard-npm into the Build GitHub Actions workflow.
Comments suppressed due to low confidence (1)

.github/workflows/build.yml:24

  • The Takumi Guard setup step is placed before actions/setup-node, but setup-node is configured with registry-url (and typically writes npm config). If Takumi Guard also configures npm/.npmrc, running it before setup-node risks having its config overwritten, so it may not apply to npm ci/npm test. Consider moving this step to run after Set up Node.js (but before npm ci).
      - uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1
      - name: Set up Node.js
        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6
        with:
          node-version: ${{ matrix.node-version }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6
with:
fetch-depth: 0
- uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For traceability in workflow logs, add a name: to this step (it currently shows up as a generic "Run flatt-security/setup-takumi-guard-npm" entry).

Suggested change
- uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1
- name: Set up Takumi Guard for npm
uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1

Copilot uses AI. Check for mistakes.
@KengoTODA KengoTODA merged commit 7e23bb7 into master Mar 25, 2026
6 checks passed
@KengoTODA KengoTODA deleted the KengoTODA-patch-1 branch March 25, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants