Add Takumi Guard setup step to build workflow#755
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Takumi Guard initialization to the CI build workflow to enable npm-related protection/validation during the build pipeline.
Changes:
- Inserted
flatt-security/setup-takumi-guard-npminto theBuildGitHub Actions workflow.
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:24
- The Takumi Guard setup step is placed before
actions/setup-node, butsetup-nodeis configured withregistry-url(and typically writes npm config). If Takumi Guard also configures npm/.npmrc, running it beforesetup-noderisks having its config overwritten, so it may not apply tonpm ci/npm test. Consider moving this step to run afterSet up Node.js(but beforenpm ci).
- uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1
- name: Set up Node.js
uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6
with:
node-version: ${{ matrix.node-version }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1 |
There was a problem hiding this comment.
For traceability in workflow logs, add a name: to this step (it currently shows up as a generic "Run flatt-security/setup-takumi-guard-npm" entry).
Suggested change
| - uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1 | |
| - name: Set up Takumi Guard for npm | |
| uses: flatt-security/setup-takumi-guard-npm@0f69e1fc4f2c4e55dd52abcafa7c4249cd6c7e50 # v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.