Added mirror and reverse feature, updated readme.md and fix some whitespaces#23
Added mirror and reverse feature, updated readme.md and fix some whitespaces#23nonepork wants to merge 6 commits intoKennyOliver:mainfrom
Conversation
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces new features to the VividHues package, specifically adding 'mirror' and 'reverse' methods to the Clr class, which manipulate strings to display them in mirrored or reversed and mirrored formats. Additionally, the PR includes updates to the README.md to document these new features and makes minor whitespace adjustments in the code.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the new 'mirror' and 'reverse' methods handle edge cases such as characters not present in the 'MIRROR_DICT' and uppercase letters.
- Correct the image URLs in the README.md to point to the correct repository path to prevent broken links.
- Consider updating the PR description to provide more clarity on the changes made and confirm the version number is correct as per the project's versioning scheme.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
|
|
||
| <br /> | ||
|
|
||
| #### :mirror: Clr.mirror() |
There was a problem hiding this comment.
issue (llm): The image URLs in the README for the mirror and reverse methods seem to have a typo in the repository path ('nonepork' instead of 'KennyOliver'). This will lead to broken image links in the documentation.
I'm not sure whether I got the version right or not. Also I don't know is this the right way to upload images :p