Skip to content

Conversation

@Johannes-callidus
Copy link
Collaborator

@Johannes-callidus Johannes-callidus commented Oct 22, 2025

This PR introduces new functions to count figures and rework figure categories to a bitflag enum and them as argument for the counting functions.

@Sephirex95
Copy link
Collaborator

Sephirex95 commented Oct 22, 2025

I was thinking about this one yesterday - I can merge that, but I would prefer if we had a proper figure counting function for areas, that would allow counting of:

  • All figures
  • Only Enemy
  • Only Citizens

Since that would be useful in more situations, and would allow us to check for figures more precisely. Outside of flotsam and gulls, of the top of my head, explosions and smoke are also figures, and I think so are projectiles?
It would help with counting we do before many other actions connected to building and repairing

@Johannes-callidus
Copy link
Collaborator Author

Which figures exactly do you mean by citizens. Legions as well?

@Sephirex95
Copy link
Collaborator

I meant human/animal figures excluding enemy.
So yeah, I'd include legions.

However, if you have time:
Ideally we should have categories in a bitflag enum, so you can pass a combined 'figure_mask', like:
Figures_citizens+ figures_legions+neutral_animals

@Johannes-callidus
Copy link
Collaborator Author

But only with figure "groups" because there are to many figure types to implement that.

@Johannes-callidus Johannes-callidus changed the title Birds and Flotsam not taken into account when deleting briges Figure counting functions Nov 7, 2025
@Johannes-callidus Johannes-callidus marked this pull request as draft November 7, 2025 14:00
@Johannes-callidus Johannes-callidus marked this pull request as ready for review November 9, 2025 08:57
@Johannes-callidus Johannes-callidus marked this pull request as draft November 9, 2025 20:28
@Johannes-callidus Johannes-callidus marked this pull request as ready for review November 10, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants