Release 3.0 #176
Release 3.0 #176
Conversation
ab78669 internal track. * Fixed an issue with SSL flags greater than 3 weren't updating IIS properly. * Fixed formatting of private SSH key when creating a temp file when using ssh. * Fixed an ACL issue on SQL Private Keys when using SSH to connect to the Windows Server. * Updated Documentation to indicate the username and password fields are automatically added via Command. --------- Co-authored-by: Sean <1661003+spbsoluble@users.noreply.github.com> Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
Merge 2.6.4 to main
There was a problem hiding this comment.
Pull request overview
This pull request titled "Release 3.0" includes updates to documentation, configuration files, images, and bug fixes primarily focused on improving the Windows Certificate Universal Orchestrator extension.
Changes:
- Added clarification text to multiple fields indicating they are "automatically created" in both JSON manifests and README documentation
- Fixed a bug in private key formatting for SSH RSA keys in the PSHelper.cs file
- Added new documentation images and expanded descriptions for custom fields and entry parameters
- Updated CHANGELOG with version 2.6.4 (note: version mismatch with PR title)
Reviewed changes
Copilot reviewed 5 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Added version 2.6.4 entry documenting bug fixes and documentation updates |
| integration-manifest.json | Updated description fields to clarify auto-created fields, added spacing to descriptions |
| README.md | Extensive documentation updates including expanded field descriptions, new images, clarification about auto-created fields, and table formatting changes |
| IISU/PSHelper.cs | Refactored formatPrivateKey method to handle different key types more generically |
| docsource/images/*.png | Added new PNG image files for documentation (binary files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,10 @@ | |||
|
|
|||
| 2.6.4 | |||
There was a problem hiding this comment.
The PR title indicates "Release 3.0" but the CHANGELOG.md shows version "2.6.4". This inconsistency could cause confusion about the actual version being released. Please ensure the version number in the CHANGELOG matches the intended release version indicated in the PR title.
| 2.6.4 | |
| 3.0 |
| | Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `Disable` | `net6.0` || Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `LatestMajor` | `net8.0` | | ||
| | `11.6` _and_ newer | `net8.0` | | `net8.0` | |
There was a problem hiding this comment.
In the README.md compatibility matrix table, lines 810-811 have formatting issues. Line 810 appears to merge two separate table rows without proper line breaks, and line 811 has trailing whitespace and inconsistent formatting. This could cause the markdown table to render incorrectly.
| | Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `Disable` | `net6.0` || Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `LatestMajor` | `net8.0` | | |
| | `11.6` _and_ newer | `net8.0` | | `net8.0` | | |
| | Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `Disable` | `net6.0` | | |
| | Between `11.0.0` and `11.5.1` (inclusive) | `net8.0` | `LatestMajor` | `net8.0` | | |
| | `11.6` _and_ newer | `net8.0` | | `net8.0` | |
| string header = privateKey.Substring(0, privateKey.IndexOf("KEY-----") + 8); | ||
| string footer = privateKey.Substring(privateKey.IndexOf("-----END")); | ||
|
|
||
| return privateKey.Replace($" {keyType} PRIVATE ", "^^^").Replace(" ", System.Environment.NewLine).Replace("^^^", $" {keyType} PRIVATE ") + System.Environment.NewLine; | ||
| return privateKey.Replace(header, "HEADER").Replace(footer, "FOOTER").Replace(" ", Environment.NewLine).Replace("HEADER", header).Replace("FOOTER", footer) + Environment.NewLine; |
There was a problem hiding this comment.
The new implementation assumes the privateKey parameter contains both "KEY-----" and "-----END" substrings. If either substring is missing, the IndexOf method will return -1, causing the Substring method to throw an ArgumentOutOfRangeException. Consider adding validation to ensure these delimiters exist before attempting to extract header and footer, or handle the exception appropriately.
rcpokorny
merged commit e295bf1
into
76022-IIS_Orchestrator-3.0.0
No description provided.