Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 1.2.3

## Bug Fixes
- fix(management): `K8SNS` and `K8SCluster` Management Remove jobs no longer throw `IndexOutOfRangeException` when alias does not contain the expected `/` delimiter.

# 1.2.2

## Bug Fixes
Expand All @@ -22,6 +27,12 @@ on missing or invalid secret field name.
## Features
- feat(client): Retry interrupted connections to k8s cluster.

# 1.1.4

## Bug Fixes
- fix(management): `K8SNS` Management Add job no longer throws `IndexOutOfRangeException` when alias does not contain the expected `/` delimiter.
- fix(management): `K8SNS` and `K8SCluster` Management Remove jobs no longer throw `IndexOutOfRangeException` when alias does not contain the expected `/` delimiter.

# 1.1.3

## Bug Fixes
Expand Down
Binary file modified docsource/images/K8SCluster-basic-store-type-dialog.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docsource/images/K8SNS-basic-store-type-dialog.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docsource/images/K8STLSSecr-basic-store-type-dialog.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions kubernetes-orchestrator-extension/Jobs/Management.cs
Original file line number Diff line number Diff line change
Expand Up @@ -688,13 +688,25 @@ private JobResult HandleRemove(string secretType, ManagementJobConfiguration con
var splitAlias = certAlias.Split("/");
if (Capability.Contains("K8SNS"))
{
if (splitAlias.Length < 2)
{
var errMsg = $"Invalid alias format for K8SNS store type. Expected pattern: 'secrets/<tls|opaque>/<secret_name>' but got '{certAlias}'";
Logger.LogError(errMsg);
return FailJob(errMsg, config.JobHistoryId);
}
// Split alias by / and get second to last element KubeSecretType
KubeSecretType = splitAlias[^2];
KubeSecretName = splitAlias[^1];
if (string.IsNullOrEmpty(KubeNamespace)) KubeNamespace = StorePath;
}
else if (Capability.Contains("K8SCluster"))
{
if (splitAlias.Length < 3)
{
var errMsg = $"Invalid alias format for K8SCluster store type. Expected pattern: '<namespace>/secrets/<tls|opaque>/<secret_name>' but got '{certAlias}'";
Logger.LogError(errMsg);
return FailJob(errMsg, config.JobHistoryId);
}
KubeSecretType = splitAlias[^2];
KubeSecretName = splitAlias[^1];
KubeNamespace = splitAlias[0];
Expand Down
Loading
Loading