Migrate to boost process v2 #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
force-pushed
the
boost-process-v2
branch
from
dcf05ea to
d3204e4
Compare
gmossessian
reviewed
Jul 17, 2025
| #else | ||
| #include <sys/resource.h> | ||
|
|
||
| #include <string> |
Contributor
Author
There was a problem hiding this comment.
string is used on line 39. However it obviously worked before, because it is implicitly included from on of the other includes.
The reason why this pops up now: The code is checked with cpplint, a static code checker. It produces an error called "include what you use". cpplint must pass as part of the checkstyle workflow run on the PR. checkstyle runs only on files that change. So with other words: Because I made a change to this file, cpplint forced me to cleanup.
gmossessian
reviewed
Jul 17, 2025
| #include <chrono> // NOLINT | ||
| #include <string> | ||
| #include <thread> // NOLINT | ||
| #include <vector> |
Contributor
Author
There was a problem hiding this comment.
same answer: string and vector are used in this file, however this file hasn't been touched since the introduction of cpplint as CI workflow.
gmossessian
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to boost process v2, fixes compile problems on newer versions of boost.
In addition: