Skip to content

Conversation

@hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented Aug 6, 2025

after updating boost in #314, this PR fixes some issues:

  • newer versions of boost require linking the process library, see Compiling Boost.Process as header-only fails  boostorg/process#390
    • older versions don't ship boost process and the upcoming 1.89 might go back to header-only
  • fix linking on macos for newer boost and remove pinning 1.85
    • reason: upstream brew package removed boost_thread-mt, now there is only boost_thread (-mt is now default), same as on Linux
    • Mac users that compile from source need to update boost
  • fix cmake deprecation warning
    • only applies to very old boost versions which aren't supported anyway, raised the minimum required versions to 1.80 for boost process v2
    • update ubuntu version for rust workflow to get newer boost there
      • rust bindings don't support keyvi index, that's why the newer boost wasn't necessary

@hendrikmuhs hendrikmuhs changed the title Fix boost process link error Update boost build env Aug 7, 2025
@hendrikmuhs hendrikmuhs marked this pull request as ready for review August 7, 2025 06:57
@hendrikmuhs hendrikmuhs merged commit aa64a62 into KeyviDev:master Aug 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant