Skip to content

Fix linker creating existing links #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZashIn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix linker creating existing links #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions src/rootbuilder/modules/rootbuilder_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,25 +28,34 @@ def build(self):
linkFileData = self.files.getRootModFiles()
else:
linkFileData = self.files.getLinkableModFiles()
linkOutputData = []

if self.paths.rootLinkDataFilePath().exists():
linkOutputData = json.load(open(self.paths.rootLinkDataFilePath(),"r", encoding="utf-8"))
else:
linkOutputData = {}

for file in linkFileData:
relativePath = self.paths.rootRelativePath(file)
gamePath = self.paths.gamePath() / relativePath
# If the linkable file is already in the game folder, rename it.
file_path = Path(file)
createLink = True
if gamePath.exists():
#qInfo("Renaming for link " + str(gamePath))
self.utilities.moveTo(gamePath, Path(str(gamePath) + ".rbackup"))
# Create the dirs if they don't exist.
if not gamePath.parent.exists():
os.makedirs(gamePath.parent)
# Try and create a link. This will fail if a link is already there.
#qInfo("Creating link for " + str(gamePath))
Path(file).link_to(gamePath)
mapping = {
"Source": str(file),
"Destination": str(gamePath)
}
linkOutputData.append(mapping)
if str(gamePath) not in linkOutputData:
# The linkable file is already in the game folder, rename it.
self.utilities.moveTo(gamePath, Path(str(gamePath) + ".rbackup"))
elif gamePath.samefile(file_path):
# This is already linked.
createLink = False
else:
# Remove old link to update with new one
gamePath.unlink()
if createLink:
# Create the dirs if they don't exist.
if not gamePath.parent.exists():
os.makedirs(gamePath.parent)
# Try and create a link. This will fail if a link is already there.
file_path.link_to(gamePath)
linkOutputData[str(gamePath)] = str(file)
# Save our link data.
if not self.paths.rootLinkDataFilePath().exists():
self.paths.rootLinkDataFilePath().touch()
Expand All @@ -59,9 +68,9 @@ def clear(self):
if self.paths.rootLinkDataFilePath().exists():
linkFileData = json.load(open(self.paths.rootLinkDataFilePath(),"r", encoding="utf-8"))
# Loop through our link data and unlink individual files.
for file in linkFileData:
destPath = Path(file["Destination"])
srcPath = Path(file["Source"])
for dest in linkFileData:
destPath = Path(dest)
srcPath = Path(linkFileData[dest])
if destPath.exists():
if os.stat(destPath).st_nlink <= 1:
self.utilities.moveTo(destPath, srcPath)
Expand Down