Open
Conversation
…ponents - Added BalooPaaji2-Bold, BalooPaaji2-Medium, and BalooPaaji2-Regular fonts to both Android and iOS asset manifests. - Updated styles in various components to utilize the new Baloo Paaji font family. - Enhanced header styles and navigation components for improved layout and user experience. - Adjusted color constants for better visual consistency in the ReaderScreen and related components.
- Added react-native-linear-gradient dependency to package.json. - Replaced multiple Baloo Paaji font files with a single variable font in asset manifests for both Android and iOS. - Updated styles across components to utilize the new variable font and improved header styles. - Enhanced SafeArea component to support top padding based on device insets. - Refactored header and navigation components for better layout and visual consistency.
- Added anvaad-js version 1.5.0 to package.json and updated yarn.lock. - Refactored color constants for improved visual consistency across components. - Enhanced styles in HomeScreen for better formatting. - Introduced new constants for minimum bottom padding and updated Gurmukhi text handling in db.js. - Integrated convertToUnicode utility in BaniList component for better text rendering.
…for night mode styling - Added a check for null rows in the getBaniTuk function to prevent errors. - Updated the color constant for night mode styling from a hardcoded value to a defined color constant for improved consistency.
- Updated the getBaniTuk function to include a check for undefined item properties in addition to null rows, improving error handling and stability.
…across components. Upgrade eslint-plugin-import to version 2.32.0, adjust MCP server URL and nonce, and enhance various components to utilize theme context for consistent styling. Remove unused styles and streamline imports for better maintainability.
- Wrapped the Navigation component with SafeAreaProvider for improved layout handling. - Utilized useCallback for header title and style calculations in useHeader hook to enhance performance. - Updated import statements for convertToUnicode utility for consistency across components. - Refactored SVG icon properties to use camelCase for stroke attributes for better compatibility.
- Changed the parameter name from 'tuk' to 'word' in the convertToUnicode function for improved readability and understanding of its purpose.
…cing, typography, and colors for improved consistency and maintainability. Update header styles, button dimensions, and text properties to align with the new theme structure. Enhance overall styling for better visual coherence.
…amline code and improve maintainability.
…paths in Babel config. Refactor BaniList and other components to remove unnecessary props and streamline imports. Remove legacy styles and unused theme definitions for improved maintainability.
…ation - Added checks to ensure the input is a string and handle cases where the input is null or undefined. - Implemented fallback to return the original word if the conversion fails or an error occurs, improving robustness.
…-sundar-gutka-readers-page 🎨 Reader UI refresh, Unicode Gurmukhi support, new bottom nav, and Baloo Paaji font
- Introduced a new optional parameter 'fontFace' to the createDiv function, allowing for dynamic font family selection. - Updated the inline style to apply the specified font family, enhancing text presentation in the ReaderScreen component.
- Removed the variable font 'BalooPaaji2-VariableFont_wght.ttf' and replaced it with 'BalooPaaji2-Regular.ttf' and 'BalooPaaji2-SemiBold.ttf' in both Android and iOS manifest files. - Updated references in the iOS project files and Info.plist to reflect the new font structure. - Adjusted font face constants in the application to align with the new font naming conventions.
🎨 Theming Refactor: central ThemeProvider, tokens, and screen-wide style updates
* add trackplayer * Refactor audio player integration and remove unused components - Updated import paths for TrackPlayerUtils and AudioPlayer. - Moved AudioPlayer to common index for better accessibility. - Removed deprecated AudioPlayer and useTrackPlayer components along with their associated utilities. - Cleaned up ReaderScreen to utilize the new structure. * Update configuration and refactor audio player integration - Added alias for @service in babel.config.js for improved module resolution. - Disabled new architecture in android/gradle.properties for compatibility. - Updated AndroidManifest.xml to export MusicService for proper functionality. - Refactored ReaderScreen to utilize the new AudioPlayer component structure. - Removed deprecated AudioPlayer component and styles from common components. - Updated TrackPlayerUtils to streamline player setup and removed unused event listeners. * Enhance audio player functionality and settings management - Updated AudioPlayer component to include navigation and title props. - Refactored audio settings in the Settings component to support auto-play and sync scroll options. - Implemented new actions and reducers for managing audio settings and manifest. - Improved API handling for fetching audio manifest and artists. - Added styles for download controls and updated localization strings for audio settings. - Removed deprecated useTrackPlayer hook to streamline audio management. * Integrate audio auto-play feature in AudioPlayer component - Added useSelector to access isAudioAutoPlay state from Redux. - Implemented useEffect to handle audio auto-play when currentPlaying is active. - Enhanced play/pause functionality to accommodate auto-play behavior. * Implement default audio track selection in useAudioManifest hook - Added useSelector to retrieve defaultAudio from Redux state. - Enhanced track selection logic to prioritize default audio track if available. - Maintained fallback to the first track in the manifest if no default track is found. * Refactor audio data mapping and API requests for improved consistency - Updated useAudioManifest hook to map API manifest data to new structure, including track_id and additional track properties. - Modified audio.jsx to enhance logging for fetched artist data. - Adjusted audioApi.js to streamline API requests for fetching manifests and artists, ensuring consistent endpoint usage. - Removed unused queue retrieval in TrackPlayerUtils.js to clean up code. * Enhance AudioPlayer component with new features and UI improvements - Introduced AudioTrackDialog and AudioControlBar components for better track selection and control. - Added BlurView overlay for improved visual aesthetics. - Updated state management to default showTrackModal to true. - Refactored play/pause and track selection functionalities for enhanced user experience. - Cleaned up unused code and styles for better maintainability. * Update project configuration and enhance ReaderScreen functionality - Added ESLint rules for unused styles and integrated react-native plugin for better linting. - Updated Babel configuration to correct service path alias. - Added new font asset (BalooPaaji2) to both iOS and Android platforms. - Enhanced ReaderScreen with animated footer and improved audio player controls. - Refactored AutoScrollComponent and AudioPlayer components for better performance and maintainability. - Removed deprecated components and streamlined imports for cleaner code structure. - Updated VSCode settings for improved development experience. * Add react-native-slider dependency and enhance AudioPlayer UI - Added @miblanchard/react-native-slider to package.json for improved audio control. - Updated AudioPlayer component to utilize the new slider for track progress. - Enhanced UI elements in AudioPlayer and related components to support night mode. - Refactored styles for better responsiveness and visual consistency. - Updated localization strings for improved user experience. * Update Firebase dependencies and enhance AudioPlayer functionality - Upgraded Firebase packages in package.json and Podfile.lock to version 12.1.0 for improved performance and features. - Refactored AudioPlayer component to utilize default audio settings from Redux state, enhancing user experience. - Introduced new hooks and state management for better audio track handling and settings. - Improved UI elements in AudioPlayer and related components for better responsiveness and visual consistency. - Updated action creators and reducers to support new default audio structure. * Refactor AudioPlayer components for improved styling and prop handling - Updated ActionComponent to dynamically set background and text colors based on night mode and selector state. - Enhanced AudioControlBar to handle optional displayName gracefully. - Modified AudioTrackDialog to allow optional title and header/footer props with default values. - Cleaned up logging in useAudioManifest hook to streamline code. * Update prop type for baniID in AudioSettingsModal to string for improved type safety * Enhance ESLint configuration and refactor imports for improved code organization - Added import/order rule to ESLint for better import organization and readability. - Refactored import statements across multiple components to maintain consistent ordering and structure. - Updated project files to ensure compliance with new ESLint rules, enhancing overall code quality. * Refactor AudioPlayer styles and components for improved UI consistency and functionality - Updated font family in styles for better readability. - Enhanced ActionComponent layout with a new wrapper for action button content. - Adjusted AudioControlBar to improve slider appearance and timestamp display. - Modified AudioTrackDialog to update button text and added new localization strings. - Refactored icon components to standardize stroke properties and improve responsiveness. * Update AudioPlayer styles to adjust gap size for improved layout consistency * Update AudioPlayer styles to adjust padding for improved layout consistency * Refactor AudioPlayer components to improve prop handling and clean up code - Removed unused props from AudioControlBar and AudioTrackDialog for better clarity. - Updated prop types in ChevronRight component to use default values, enhancing type safety. * Update dependencies and enhance project configuration for improved performance - Upgraded react-native-gesture-handler to version 2.28.0 for better gesture handling. - Updated Android Gradle plugin to version 8.8.2 for improved build performance. - Incremented versionCode in Android app build.gradle for the upcoming release. - Modified MCP server configuration for updated local development settings. - Refactored font assets in ReaderScreen to replace deprecated variable font with regular and semi-bold variants. - Enhanced ReaderScreen components for better responsiveness and UI consistency. - Cleaned up unused imports and improved code organization across various components. * Refactor AudioPlayer and ReaderScreen components for enhanced functionality and styling - Updated AudioPlayer to include webViewRef prop for improved audio sync scrolling. - Enhanced ReaderScreen's AudioPlayer integration for better layout and responsiveness. - Added new useAudioSyncScroll hook for synchronized scrolling behavior. - Improved styles in AudioPlayer components for better UI consistency. - Refactored gutkaScript to handle scrollToSequence action for better user experience. * Refactor AudioPlayer and useAudioSyncScroll for improved audio synchronization - Updated useAudioSyncScroll to fetch LRC data based on audioUrl, enhancing synchronization with audio playback. - Simplified parameters in useAudioSyncScroll by removing unused artistID and baniID. - Removed deprecated timestamp files and cleaned up related imports for better code organization. - Adjusted dummy data track IDs for consistency across audio tracks. * Fix condition in useAudioSyncScroll to streamline current sequence detection * Add scroll timeout management in useAudioSyncScroll for improved performance - Introduced scrollTimeoutRef to manage scroll delays and prevent rapid calls. - Added cleanup logic to clear timeouts on component unmount and state changes. - Enhanced stability of audio synchronization scrolling behavior. * Enhance AudioControlBar and useAudioSyncScroll for improved styling and validation - Updated AudioControlBar to use TERTIARY_COLOR for background and border styling, enhancing visual consistency. - Added sequence number validation in useAudioSyncScroll and gutkaScript to ensure safe scrolling behavior. - Improved handling of audio synchronization by sanitizing input values for sequence scrolling. * Add Toast notifications and error handling in audio synchronization - Integrated react-native-toast-message for displaying notifications. - Enhanced useAudioSyncScroll to show error messages for audio sync issues and API failures. - Updated common index to export toast functions for better error management across the application. * Improve error handling in audio API requests - Updated error handling in makeApiRequest to display toast notifications for API failures and network errors. - Enhanced user feedback by informing users of connection issues and temporary unavailability of audio features. * fix: styling * Update dependencies and refactor styles for improved theming support across components. Upgrade eslint-plugin-import to version 2.32.0, adjust MCP server URL and nonce, and enhance various components to utilize theme context for consistent styling. Remove unused styles and streamline imports for better maintainability. * Refactor styles across multiple components to utilize theme-based spacing, typography, and colors for improved consistency and maintainability. Update header styles, button dimensions, and text properties to align with the new theme structure. Enhance overall styling for better visual coherence. * Remove unused theme prop validation from BaniHeader component to streamline code and improve maintainability. * Enhance theming support by adding new aliases for settings and theme paths in Babel config. Refactor BaniList and other components to remove unnecessary props and streamline imports. Remove legacy styles and unused theme definitions for improved maintainability. * Add Baloo Paaji fonts to asset manifests and update styles across components - Added BalooPaaji2-Bold, BalooPaaji2-Medium, and BalooPaaji2-Regular fonts to both Android and iOS asset manifests. - Updated styles in various components to utilize the new Baloo Paaji font family. - Enhanced header styles and navigation components for improved layout and user experience. - Adjusted color constants for better visual consistency in the ReaderScreen and related components. * Update font assets and styles; integrate react-native-linear-gradient - Added react-native-linear-gradient dependency to package.json. - Replaced multiple Baloo Paaji font files with a single variable font in asset manifests for both Android and iOS. - Updated styles across components to utilize the new variable font and improved header styles. - Enhanced SafeArea component to support top padding based on device insets. - Refactored header and navigation components for better layout and visual consistency. * Add anvaad-js dependency and update styles and constants - Added anvaad-js version 1.5.0 to package.json and updated yarn.lock. - Refactored color constants for improved visual consistency across components. - Enhanced styles in HomeScreen for better formatting. - Introduced new constants for minimum bottom padding and updated Gurmukhi text handling in db.js. - Integrated convertToUnicode utility in BaniList component for better text rendering. * Fix BaniList component to handle null rows and update color constant for night mode styling - Added a check for null rows in the getBaniTuk function to prevent errors. - Updated the color constant for night mode styling from a hardcoded value to a defined color constant for improved consistency. * Enhance BaniList component to handle undefined item cases - Updated the getBaniTuk function to include a check for undefined item properties in addition to null rows, improving error handling and stability. * Integrate SafeAreaProvider in App component and optimize header styles - Wrapped the Navigation component with SafeAreaProvider for improved layout handling. - Utilized useCallback for header title and style calculations in useHeader hook to enhance performance. - Updated import statements for convertToUnicode utility for consistency across components. - Refactored SVG icon properties to use camelCase for stroke attributes for better compatibility. * Refactor convertToUnicode utility function parameter for clarity - Changed the parameter name from 'tuk' to 'word' in the convertToUnicode function for improved readability and understanding of its purpose. * Enhance convertToUnicode function with error handling and input validation - Added checks to ensure the input is a string and handle cases where the input is null or undefined. - Implemented fallback to return the original word if the conversion fails or an error occurs, improving robustness. * merge * Add fontFace parameter to createDiv function for customizable typography - Introduced a new optional parameter 'fontFace' to the createDiv function, allowing for dynamic font family selection. - Updated the inline style to apply the specified font family, enhancing text presentation in the ReaderScreen component. * Update font assets and manifest files - Removed the variable font 'BalooPaaji2-VariableFont_wght.ttf' and replaced it with 'BalooPaaji2-Regular.ttf' and 'BalooPaaji2-SemiBold.ttf' in both Android and iOS manifest files. - Updated references in the iOS project files and Info.plist to reflect the new font structure. - Adjusted font face constants in the application to align with the new font naming conventions. * Update theme handling in gutkaScript and remove SettingsIcon from icon exports - Changed the night mode color handling in gutkaScript to use the theme mode for better consistency with the overall theme. - Removed the SettingsIcon export from the icons index file, streamlining the available icons. * Refactor ReaderScreen components and enhance theme integration - Reorganized the structure of ReaderScreen components to improve readability and maintainability. - Updated components to utilize the new theme context for consistent styling across the application. - Added a Music icon to the BottomNavigation and adjusted navigation handling based on audio state. - Enhanced audio player components with improved styling and functionality, including dynamic color handling based on theme. - Removed deprecated font references and ensured all components align with the updated typography and spacing conventions. * Added close button and blur view * Enhance Bookmarks and ReaderScreen components with BottomNavigation integration - Added BottomNavigation to the Bookmarks component for improved navigation. - Updated ReaderScreen to utilize BottomNavigation with dynamic active key based on audio state. - Refactored AudioPlayer components to include onCloseTrackModal functionality for better user experience. - Removed deprecated BottomNavigation component files and ensured proper imports across the application. - Adjusted localization strings for consistency in audio settings terminology. * Refactor ReaderScreen and HomeScreen components for improved functionality and styling - Added StatusBarComponent to HomeScreen for consistent status bar appearance. - Removed unnecessary margin styles in HomeScreen and ReaderScreen styles for cleaner layout. - Updated BaniHeader component to improve import order and structure. - Enhanced AudioPlayer component with playback speed control and improved download management. - Refactored AudioSettingsModal to allow dynamic playback speed adjustments. - Improved error handling and user feedback in audio download processes. - Adjusted localization strings for better clarity in audio settings terminology. * Enhance audio synchronization and scrolling behavior in ReaderScreen - Integrated paragraph mode support in the audio synchronization scroll functionality. - Improved element selection for scrolling based on paragraph mode, utilizing CSS selectors for better performance. - Added highlight management for the currently scrolled element to enhance user experience. - Updated database handling to include sequence information for paragraphs, improving data structure and retrieval. * Update baniID prop type in AudioTrackDialog from number to string for improved type consistency * Remove hardcoded BASIC_AUTH_PASSWORD in constant.js for enhanced security * Refactor error handling in AudioPlayer and related hooks to use centralized logging - Replaced console.error statements with logError for consistent error logging across AudioPlayer, useAudioManifest, useDownloadManager, and useTrackPlayer. - Removed unnecessary local file existence checks in AudioPlayer for cleaner code. - Enhanced error handling in TrackPlayerUtils and rnfs for improved debugging and maintenance. * Improve error logging in TrackPlayerUtils for better debugging - Added detailed error messages in logError calls to include error details for addTrack, pauseTrack, stopTrack, and resetPlayer functions. - Ensured consistent error handling by logging missing track URL errors. * Refactor Header component and update styles for improved layout - Adjusted Header component structure to use styled views for left, center, and right sections. - Updated styles to ensure proper alignment and spacing within the header. - Enhanced overall responsiveness by modifying width properties and flex settings in the header styles. * Update highlight color and border radius in gutkaScript for improved UI consistency - Replaced hardcoded highlight color with a static color from the theme for better maintainability. - Added border radius to highlighted elements to enhance visual appeal. * Enhance AudioPlayer and related components with improved error handling and loading states - Integrated loading state management in AudioTrackDialog and AudioControlBar for better user feedback during audio operations. - Added error toast notifications in AudioPlayer for playback, seeking, and track switching failures to enhance user experience. - Refactored useAudioManifest to streamline track fetching and default track setting logic. - Updated TrackPlayerUtils to implement a singleton service for TrackPlayer initialization and cleanup, improving performance and reliability. - Enhanced analytics error handling to prevent crashes during event tracking. * Update .gitignore to exclude android/node and add node directory for better project management
…veness (#305) - Reintroduced the STRINGS import in the Header component for better localization support. - Updated Header styles to change alignment from "center" to "flex-end" and set a fixed height for consistency across different devices.
* Refactor AboutScreen and DatabaseUpdate components to use CustomText for consistent text rendering. Clean up unused imports and improve code readability across multiple files. * Refactor components to use CustomText for consistent text rendering - Updated AutoScrollComponent, DatabaseUpdateBanner, and FallbackComponent to replace Text with CustomText for improved text consistency. - Cleaned up unused imports in the affected files. * fix: fix lint error * Refactor components to utilize ListItemTitle for improved consistency in list item rendering - Replaced instances of ListItem.Title with the new ListItemTitle component across various settings and audio player components for uniformity. - Updated imports and adjusted styles where necessary to maintain visual consistency and enhance maintainability. * Refactor DownloadBadge component to use CustomText for consistent text rendering - Replaced Text component with CustomText in DownloadBadge for improved text consistency. - Updated imports to reflect the changes and maintain code clarity. * Fix import path for ListItemWithIcon component to ensure consistent casing in index file * Update styles across components to utilize Baloo Paaji font family - Replaced Arial font with Baloo Paaji in ReaderScreen and Bookmarks styles for consistency. - Introduced headerTitleStyle in Settings to apply Baloo Paaji SemiBold font. - Updated CustomText and ListItemTitle components to use Baloo Paaji font dynamically. - Removed unused Arial constant from constants file to streamline font management.
- Added paddingBottom to the BottomNavigation styles for better spacing. - Increased height of iconContainer to ensure consistent icon display.
* Update versioning, enhance audio player functionality, and improve theme integration - Incremented versionCode to 170 and versionName to "5.9" in build.gradle for the upcoming release. - Refactored AudioPlayer component to streamline props and improve functionality, including removal of unused props. - Enhanced audio synchronization and scrolling behavior in ReaderScreen with improved error handling and loading states. - Updated theme colors in darkTheme and lightTheme for better visual consistency across components. - Cleaned up imports and adjusted styles in various components for improved maintainability and responsiveness. * Enhance AudioControlBar and AudioSettingsModal with lyrics availability check - Added functionality to check for the availability of lyrics files in the AudioControlBar component. - Integrated loading indicators in AudioControlBar and AudioTrackDialog for improved user experience during audio operations. - Updated AudioSettingsModal to conditionally disable options based on lyrics availability. - Refactored related components to streamline props and enhance maintainability. * Refactor AudioPlayer styles and ActionComponent layout for improved UI consistency - Updated audioControlBarStyles to set a fixed height for the control bar, enhancing layout stability. - Adjusted ActionComponent to wrap the icon in a new container for better alignment and responsiveness. - Modified icon size for improved visual consistency across the audio player interface.
* Enhance permission handling in notifications.js for better error management - Updated checkBroadcastPermission function to use a fallback for permission string, improving compatibility across Android versions. - Added error handling to log and display toast notifications when permission checks fail, enhancing user feedback and debugging capabilities. * Enhance localization by adding PERMISSION_ERROR strings for improved user feedback on broadcast permission failures in multiple languages.
* Update localization and error handling in audio components - Introduced STRINGS for improved localization in various components, including AudioPlayer and AudioSettingsModal. - Enhanced error messages in audio API requests and playback functionalities to provide clearer user feedback. - Refactored styles in ReaderScreen and related components for better layout consistency and responsiveness. - Updated header styles to utilize theme colors and improve visual coherence. * Enhance Header component with bookmark functionality and update styles for improved layout - Added handleBookmarkPress prop to Header component for bookmark functionality. - Updated ReaderScreen to pass bookmark handler to Header. - Adjusted styles in header to improve alignment and spacing, ensuring better responsiveness. * Refactor header components to use BackIconComponent and SettingsIconComponent for improved consistency - Replaced Icon imports with BackIconComponent in various header components for uniformity. - Updated header interaction methods to use handleBackPress for better clarity. - Enhanced BaniHeader to utilize SettingsIconComponent for navigation to settings. - Cleaned up imports and adjusted styles for improved maintainability across components.
* Refactor components and enhance BottomNavigation integration - Updated StatusBarComponent background color in multiple components for visual consistency. - Integrated BottomNavigation into HomeScreen, Bookmarks, ReaderScreen, and Settings for improved navigation. - Simplified BaniHeader component by removing unused props and imports. - Enhanced BottomNavigation functionality to dynamically handle navigation based on current state. - Added localization strings for new navigation items to support multiple languages. * Fix: Simplify icon size handling in BottomNavigation component - Updated the icon size in the BottomNavigation component to a fixed value of 24 for consistency, removing conditional logic based on active key. * Refactor BottomNavigation integration in Bookmarks and HomeScreen components - Removed hardcoded navigation items from Bookmarks component and updated BottomNavigation to directly use the navigation prop for improved flexibility. - Cleaned up imports and streamlined code in HomeScreen by removing the BottomNavigation component, enhancing overall maintainability. * Add bookmark navigation functionality in ReaderScreen - Implemented handleBookmarkPress function to navigate to the bookmarks screen when the bookmark button is pressed. - Updated ReaderScreen to utilize the new bookmark handler, enhancing user navigation experience. * Enhance BottomNavigation with localization support - Added localization strings for navigation items in BottomNavigation, improving accessibility and user experience. - Updated the rendering of navigation item text to utilize localized strings instead of hardcoded values. * Refactor AudioSettingsModal for improved functionality and code clarity - Removed unused audio toggle functionality to streamline the component. - Adjusted audio playback speed validation to allow a range from 0.5 to 2.0 for better user control. - Updated the disabled state for speed adjustment buttons to reflect the new playback speed limits. * Update localization strings and refactor ReadIcon component - Translated localization strings for HOME, READ, and MUSIC to enhance user experience. - Updated ReadIcon component to set default props for size and color, improving flexibility and usability.
…ce (#317) - Updated text in AudioTrackDialog to utilize localized strings for better internationalization support. - Enhanced user feedback by replacing hardcoded messages with dynamic string references for audio availability and request prompts. - Added new localization strings for consistent messaging across multiple languages.
* fix audio functionality * fix tests * fix deep scan bugs * fix: bugs by uttamdeep kaur * fix: auto play issue with trackPlayer * added test suite for AudioTrackDialog * Refactor AudioPlayer and AudioTrackDialog components - Removed console.log statements from AudioPlayer to clean up the code. - Updated prop types in AudioTrackDialog to include new properties: displayName, audioUrl, lyricsUrl, trackLengthSec, and trackSizeMB for better data structure and validation. - Adjusted import path in AudioControlBar test file for consistency.
* Updated the safeAreaView for bottom navigation * Add SafeArea mock component to common test utilities
.cursor/mcp.json
Outdated
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "mcpServers": { | |||
| "RadonAi": { | |||
There was a problem hiding this comment.
Should we be adding cursor mcp files in Github?
* fix audio functionality * fix tests * fix deep scan bugs * fix: bugs by uttamdeep kaur * fix: auto play issue with trackPlayer * added test suite for AudioTrackDialog * switching artists * Refactor AudioPlayer and AudioControlBar for improved track handling - Removed console.log statements from AudioPlayer for cleaner code. - Updated track selection logic in AudioPlayer to correctly handle progress saving. - Added loading indicator in AudioControlBar during track seeking. - Enhanced styles for progress bar and loading overlay. - Adjusted setAudioProgress action to remove duration parameter for better clarity. * Refactor AudioControlBar for improved progress handling - Simplified track ID and lyrics URL retrieval for clarity. - Ensured reset function is called after saving audio progress. - Updated tests to verify reset function call after progress update. * Enhance AudioControlBar and related utilities for better audio progress management - Added loading state during track seeking in AudioControlBar. - Refactored LRC data fetching into a separate function for improved readability and error handling. - Updated tests to accommodate changes in audio progress action parameters.
* fix audio functionality * fix tests * fix deep scan bugs * fix: bugs by uttamdeep kaur * fix: auto play issue with trackPlayer * added test suite for AudioTrackDialog * Refactor AudioPlayer and AudioTrackDialog components - Removed console.log statements from AudioPlayer to clean up the code. - Updated prop types in AudioTrackDialog to include new properties: displayName, audioUrl, lyricsUrl, trackLengthSec, and trackSizeMB for better data structure and validation. - Adjusted import path in AudioControlBar test file for consistency. * Added Fallback for audio url * refactor: enhance audio and lyrics existence checks in useAudioManifest - Updated the logic to handle file existence checks for audio and lyrics more robustly, ensuring that errors during checks are caught and treated as missing files. - Added remoteUrl to the audio manifest for better track information management.
- Removed the `handleBackPress` function from multiple header components, directly utilizing the `useNavigation` hook in the `BackIconComponent` for cleaner code. - Updated the `EditBaniOrder` and `Header` components to eliminate unnecessary props and streamline their interfaces. - Changed localization strings for "MUSIC" to "Audio" across various languages for improved clarity.
) * Updated the safeAreaView for bottom navigation * Add SafeArea mock component to common test utilities * Refactor ReaderScreen styles and improve auto-scroll functionality - Updated the Animated.View in ReaderScreen to use a new style for better layout management. - Enhanced styles in index.js by adding zIndex and elevation properties to improve component stacking and visibility. - Cleaned up the container style for better responsiveness and visual consistency. * fix: bottom navigation for 3-button navigation.
* Refactor AudioPlayer and styles for improved error handling and UI consistency - Renamed `createByText` to `createdByText` in AboutScreen styles for clarity. - Removed unused `CustomText` import in CheckUpdate component. - Enhanced AudioPlayer to include error handling with `ErrorFallback` component during initialization. - Updated styles in AudioPlayer to utilize theme-based border radius for consistency. - Added new localization strings for audio player preparation messages in multiple languages. * Enhance AudioPlayer error handling and UI improvements - Added manifest error handling in AudioPlayer to display appropriate fallback messages. - Refactored error handling logic into a reusable renderErrorFallback function for better code organization. - Updated styles for ErrorFallback component to improve button padding, border radius, and text size for a more consistent UI. - Introduced manifestError state in useAudioManifest hook to manage errors during audio manifest fetching. * Fix manifest error handling in AudioPlayer component - Updated the error message logic to ensure a fallback message is displayed correctly when a manifest error occurs. - Removed unnecessary conditional check for manifestError to streamline the error handling process. * Enhance AudioPlayer component with loading state and improved error handling - Introduced a Loading component to indicate audio initialization and track loading states. - Refactored error handling in AudioPlayer to streamline the display of error messages and retry options. - Updated ErrorFallback component to accept dynamic titles and button actions for better user interaction. - Removed unnecessary loading states from AudioControlBar and AudioTrackDialog for cleaner UI. - Added new localization strings for improved user feedback during audio player initialization. * Refactor AudioPlayer for improved performance and maintainability - Added useMemo and useCallback hooks to optimize rendering and prevent unnecessary re-renders. - Combined useEffect hooks to streamline logic for closing the track modal and managing audio playback state. - Enhanced handleTrackSelect function to simplify track selection and modal closure. - Memoized error fallback and audio track dialog renderers for better performance. - Improved overall code organization and readability. * Enhance AudioControlBar and ErrorFallback components - Added ActivityIndicator to AudioControlBar for improved loading feedback during audio operations. - Refactored tests in AudioControlBar to utilize a new renderComponent function for better async handling. - Updated ErrorFallback component to improve error messaging and button interactions, including dynamic titles and button actions. - Removed redundant loading state checks in AudioTrackDialog tests for cleaner test cases. * fix: style * Enhance ErrorFallback component with dynamic styling - Introduced useMemo for font styling to optimize rendering. - Updated title display logic to utilize new styles for better visual consistency. - Simplified conditional rendering for the baniTitle to improve readability.
* Enhance testing and functionality of BottomNavigation component - Updated BottomNavigation to utilize the useNavigation hook for improved navigation handling. - Simplified props by removing the navigation prop and managing navigation state internally. - Added logic to conditionally display navigation items based on the previous route, enhancing user experience when transitioning between screens. - Improved test coverage for BottomNavigation, including scenarios for navigating from different routes and ensuring correct audio state management. - Mocked useNavigation in tests to ensure accurate navigation behavior during component rendering. * Implement early return in handleTrackSelect for null or undefined selectedTrack in AudioPlayer component * Refactor BottomNavigation component to use useCallback for getCurrentRouteName function - Updated getCurrentRouteName to utilize useCallback for improved performance and to prevent unnecessary re-renders. - Enhanced the import statement to include useCallback from React, aligning with best practices for functional components.
…nks for consistency. (#357)
- Introduced touch event handling to manage auto-scroll behavior during user interactions. - Added logic to resume auto-scroll after touch events if it was previously active, improving user experience during scrolling.
* Improved the analytics and log events. * Refactor FallbackComponent and Navigation for improved analytics tracking - Updated FallbackComponent to use a constant for screen tracking. - Enhanced Navigation component to handle state changes more robustly, including error logging for performance trace failures and improved screen view tracking. * Refactor summarizeState function in crashlytics middleware - Replaced Object.entries with a for...of loop for better readability and performance. - Updated logic to skip undefined values using continue statement, improving clarity of the code. * Added analytics for Sundar Gutka Audio (#351) * Enhance audio tracking and language validation in HomeScreen and AudioPlayer components - Added language validation logic in HomeScreen to ensure valid language selection. - Integrated new analytics tracking for audio events, including artist listening duration and audio requests. - Updated AudioControlBar to utilize the new useArtistListeningDuration hook for tracking listening time. - Refactored AudioTrackDialog to include analytics tracking for audio link requests. - Improved import structure in various components for better organization and clarity. * fixed * fix: test * Enhance audio link request tracking in AudioPlayer component - Integrated analytics tracking for audio link requests by adding trackAudioEvent. - Updated buttonPress logic to handle errors gracefully when opening the audio request URL. - Improved user experience by ensuring a fallback mechanism for URL opening failures.
- Removed unused audio sync scroll functionality and related state management for a cleaner codebase. - Updated audio settings configuration to streamline the audio options presented to users, focusing on audio and auto-play features.
* Refactor ReaderScreen to use element IDs for scroll position management - Updated state management to track current element ID instead of position. - Modified saveScrollPosition to dispatch element ID when leaving the screen or app goes to background. - Enhanced WebView message handling to capture and utilize element IDs for scrolling. - Removed savePosition parameter from HTML template and related scripts for cleaner code. - Added comprehensive tests for new functionality and ensured existing features remain intact. * Refactor tests in ReaderScreen for improved readability and structure - Simplified test setup by removing unnecessary mock navigation listeners. - Enhanced code formatting for better clarity in test cases. - Updated asynchronous handling in tests to ensure proper execution flow.
- Dark scroll bar behavior is default behavior for iOS and reader can see the scroll bar on iOS - On android, scroll bar is not as visible as iOS in dark mode - Solution with the least interference with other react-native UI code was to implement android level changes - Created a custom scrollbar and added it system wide across themes
- Removed the allowTracking call from app.js to streamline initialization. - Integrated allowTracking in HomeScreen, utilizing isStatistics state for conditional tracking. - Updated allowTracking function in analytics.js to accept isStatistics parameter for improved analytics management. - Cleaned up unused imports and code in transliteration.jsx for better maintainability.
* Refactor ReaderScreen to improve scroll position management - Updated currentElementId handling to utilize a ref for better performance and consistency. - Enhanced saveScrollPosition logic to ensure accurate element ID dispatching. - Modified WebView message handling to account for reaching the end of the document, improving user experience during scrolling. - Cleaned up unnecessary state updates related to currentElementId for a more streamlined codebase. * fix: reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Highlights:
🅰️ Added new Baloo Paaji font — try it under Settings → Font Face
🧭 Revamped Bottom Navigation Design on the Bani Reader page
🎨Update the design for bani reader page.
🎧 Introduced Audio Player with support for multiple tracks
🎨 Added New and Centralized Styling.