Open
Conversation
…nd UI responsiveness - Updated handleSeek function in AudioPlayer to use useCallback for better performance. - Enhanced AudioControlBar with new slider handling logic, including optimistic updates during dragging. - Implemented state management for slider value and seek loading to improve user experience. - Added scroll state reset functionality in useAudioSyncScroll to handle seeking more effectively.
Gauravjeetsingh
requested changes
Jan 7, 2026
Collaborator
Gauravjeetsingh
left a comment
Gauravjeetsingh
left a comment
There was a problem hiding this comment.
Minor change, plus some clarity needed for the logic used.
Comment on lines
307
to
314
| // Prevent concurrent seeks | ||
| if (isSeekingRef.current || !isAudioEnabled) { | ||
| setIsSliding(false); | ||
| return; | ||
| } | ||
|
|
||
| // Update UI immediately (optimistic update) | ||
| setIsSliding(false); |
Collaborator
There was a problem hiding this comment.
setIsSliding(false) is repeating here. So we can setIsSliding before if, and inside if we can just return.
| const previousPosition = previousPositionRef.current; | ||
|
|
||
| // Detect seek: if position jumps more than 2 seconds, it's likely a seek | ||
| // Normal playback won't jump more than ~1 second per update |
Collaborator
There was a problem hiding this comment.
I didn't get this logic. What do we mean by a normal update here?
amitojsingh
changed the title
- Added setIsSeekLoading(false) to ensure loading state is reset after seeking operations. - Updated test timeouts for better reliability in asynchronous tests. - Improved test assertions for slider state and function calls to enhance clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronization scrolling issue has been resolved. Previously, seeking forward or backward did not scroll to the desired page. This issue has been fixed in the PR.