Commit f09641e
authored
Enable lint rule to encourage use of WB ResponsiveTabs/ResponsiveNavigationTabs (#3272)
## Summary:
Wonder Blocks now has new ResponsiveTabs and ResponsiveNavigationTabs components that switches to a dropdown when there is limited space. In general, these components should be preferred for improved accessibility and responsiveness since it avoids 2 dimensional scrolling for users. For more details, check out the [release notes](https://khanacademy.atlassian.net/wiki/x/DoCGDwE)!
To help encourage the use of these new components, we enable a lint rule that disables imports for the NavigationTabs and Tabs components.
Currently, there is one instance of Tabs in Perseus for the keypad. Since this is rendered in a Popover, it is an exception since it is not ideal for the tabs to turn into a dropdown within a popover. Because of this, it is fine to leave the current `Tabs` usage as is, and the lint rule can be used for future use cases where the tabs pattern is needed.
A similar lint rule was enabled in frontend in: Khan/frontend#8276
Issue: FEI-7513
## Test plan:
- Confirm a lint error is generated when Tabs or NavigationTabs is imported
<img width="906" height="285" alt="Screenshot 2026-02-19 at 3 59 17 PM" src="https://github.com/user-attachments/assets/c730cdc9-198d-43c7-a7e3-4ce48f065f38" />
<img width="924" height="288" alt="Screenshot 2026-02-19 at 3 53 49 PM" src="https://github.com/user-attachments/assets/1bb6e8d8-c1df-4094-a65f-2b38e1206d8e" />
- Confirm lint continues to pass
Author: beaesguerra
Reviewers: beaesguerra, ivyolamit, #wonder-blocks
Required Reviewers:
Approved By: ivyolamit
Checks: ⏭️ 1 check has been skipped, ✅ 10 checks were successful
Pull Request URL: #32721 parent 299c87e commit f09641e
File tree
4 files changed
+17
-1
lines changed- .changeset
- packages/math-input/src
- components/keypad
4 files changed
+17
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
309 | 322 | | |
310 | 323 | | |
311 | 324 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments