Skip to content

WIP - Rename getUserInputMap to getUserInput #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: tb/LEMS-2523/merge-get-user-input-map
Choose a base branch
from

Conversation

Myranae
Copy link
Contributor

@Myranae Myranae commented Jun 12, 2025

Summary:

After #2590, to finalize the consolidation of the two types of getUserInput on renderer, this PR renames getUserInputMap to just getUserInput so there is no confusion or reference to multiple user input methods. All files should just be a change from *.getUserInputMap() to *.getUserInput().

Issue: LEMS-2523

Test plan:

  • Confirm all tests pass
  • Do a test bump in Webapp and see what code needs to be updated with the new name
  • Confirm all Webapp tests pass
  • Probably some manual testing

@Myranae Myranae self-assigned this Jun 12, 2025
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Size Change: 0 B

Total Size: 472 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.7 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 98.6 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.js 20.5 kB
packages/perseus-editor/dist/es/index.js 91.2 kB
packages/perseus-linter/dist/es/index.js 7.14 kB
packages/perseus-score/dist/es/index.js 9.23 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 200 kB
packages/perseus/dist/es/strings.js 7.56 kB
packages/pure-markdown/dist/es/index.js 1.22 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jun 12, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (59e449b) and published it to npm. You
can install it using the tag PR2591.

Example:

pnpm add @khanacademy/perseus@PR2591

If you are working in Khan Academy's frontend, you can run the below command.

./tools/bump_perseus_version.ts -t PR2591

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR2591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant