[Simple Markdown] Remove deprecated APIs and features (html output) #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (html output) from simple-markdown
|
Size Change: -726 B (-0.15%) Total Size: 480 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (dd13ccf) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2690If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.ts -t PR2690If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2690 |
…ut support (and other deprecated APIs)
jeremywiebe
commented
Jul 9, 2025
| ) { | ||
| var parsed = blockParse(tableSrc + "\n"); | ||
| assert.strictEqual(parsed[0].type, "table"); | ||
| var actualAligns = parsed[0].align; | ||
| validateParse(actualAligns, expectedAligns); |
There was a problem hiding this comment.
validateParse() is really a glorified wrapper around an equality assertion, we were fighting the types here so I've just reverted to use... expect() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes long-deprecated features and APIs from the
@khanacademy/simple-markdownproject. We haven't used HTML output for a long, long time (everything is rendered to React) and so that is being removed.There are also a few APIs that are marked as deprecated that I've verified as unused, which we can delete.
This work is being done because I need to make another change and thought it would be handy to clean up the library a bit before doing any new work.
Issue: LEMS-3096
Test plan:
pnpm tscpnpm testInstall the snapshot version of the package in the frontend repo and type check everything there.