Remove ScrollableView left and right fade #2779
Conversation
…ollableView left and right fade
🗄️ Schema Change: No Changes ✅ |
|
Size Change: -97 B (-0.02%) Total Size: 496 kB
ℹ️ View Unchanged
|
🛠️ Item Splitting: No Changes ✅ |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a5fe54d) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2779If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2779If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2779 |
| @@ -5,31 +5,3 @@ | |||
| gap: 0.8rem; | |||
| padding: 1.2rem; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These styling is no longer necessary and redundant, fade is already done in multiple-choice.
| background: linear-gradient( | ||
| to left, | ||
| transparent, | ||
| white calc(var(--perseus-multiple-choice-spacing) / 2) | ||
| var(--wb-semanticColor-core-foreground-inverse-strong) |
There was a problem hiding this comment.
use semantic color here equivalent to white so that when WB supports the dark theme mode, this will be the inverse color.
ivyolamit
requested review from
mark-fitzgerald,
SonicScrewdriver,
anakaren-rojas and
nishasy
as code owners
| background: linear-gradient( | ||
| to left, | ||
| transparent, | ||
| white calc(var(--perseus-multiple-choice-spacing) / 2) | ||
| var(--wb-semanticColor-core-foreground-inverse-strong) |
There was a problem hiding this comment.
You could possibly add a comment here explaining what this styling is doing -- it might help new engineers understand the purpose of the styling. :)
ivyolamit
added
the
project: new radio widget
Summary:
Remove ScrollableView left and right fade.
By removing the fade styling in ScrollableView component it will no longer hinder the dark mode settings.
And by updating the existing multiple choice fade styling to use semantic colors, this will allow us in the future to support the dark mode once available in WonderBlocks.
Issue: LEMS-3108
Aug-08-2025.13-10-43.mp4
Test plan: