Remove sloc and pnpm as package dependencies - unused #3212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: 0 B Total Size: 485 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: NOT PublishedOh noes!! We couldn't find any changesets in this PR (e5ed279). As a result, we did not |
jeremywiebe
force-pushed
the
jer/rm-unused-deps
branch
from
9aa724a to
e5ed279
Compare
jeremywiebe
commented
Jan 30, 2026
| "jest-specific-snapshot": "^5.0.0", | ||
| "knip": "^5.33.3", | ||
| "nyc": "^15.1.0", | ||
| "pnpm": "^9.15.4", |
Collaborator
Author
There was a problem hiding this comment.
We don't need to "depend" on pnpm this way... plus, we use pnpm v10 not v9 today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I was checking something in Perseus and noticed neither of these dependencies are needed. I suspect we haven't used the
sloctool (used to count lines of code) in a long time (and if we want to, we can install it manually run it, and move on).pnpmis not needed as a dep at all and I'm not sure why I added it in the first place. :/Issue: --none--
Test plan: