Apply correct coordinate wrapping for REPEAT mode in Image1D/2D/3D#335
Merged
jeffamstutz merged 1 commit intoKhronosGroup:next_releasefrom Jan 6, 2026
Merged
Conversation
|
|
jeffamstutz
reviewed
Jan 5, 2026
griffin28
requested changes
Jan 5, 2026
Collaborator
griffin28
left a comment
griffin28
left a comment
There was a problem hiding this comment.
fract() should be applied to mirrorRepeat wrap mode also.
Ensure that texture coordinates are wrapped using fract() when the wrap mode is REPEAT in Image1D, Image2D, and Image3D samplers. This fixes incorrect sampling at texture boundaries for repeating textures. Adds a fract() helper to helium_math.h for this purpose.
sankhesh
force-pushed
the
texcoord_repeat
branch
from
20f44a4 to
9c68e4c
Compare
Contributor
|
LGTM, thanks @sankhesh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that texture coordinates are wrapped using fract() when the wrap mode is REPEAT in Image1D, Image2D, and Image3D samplers. This fixes incorrect sampling at texture boundaries for repeating textures. Adds a
fract()helper tohelium_math.hfor this purpose.The below images were created with VTK and
helidewith a texture coodinate range of [0,1] along the Y axis and a texture wrapping mode asREPEAT.