support visible parameter on volume and surface objects#338
Merged
jeffamstutz merged 1 commit intoKhronosGroup:next_releasefrom Feb 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a visible parameter to helide Surface and Volume objects so applications can toggle whether they participate in rendering (surface Embree BLS build / volume ray intersection).
Changes:
- Add
visibleparameter plumbing tohelide::Surfaceandhelide::Volume(defaulting totrue). - Skip invisible volumes during
Group::intersectVolumes(). - Skip invisible surfaces when constructing a Group’s Embree scene (BLS).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/devices/helide/world/Group.cpp |
Uses isVisible() to filter surfaces/volumes during scene construction and volume intersection. |
src/devices/helide/volume/Volume.h |
Adds isVisible() API and m_visible state. |
src/devices/helide/volume/Volume.cpp |
Commits visible parameter and implements isVisible(). |
src/devices/helide/surface/Surface.h |
Adds isVisible() API and m_visible state. |
src/devices/helide/surface/Surface.cpp |
Commits visible parameter and implements isVisible(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeffamstutz
force-pushed
the
helide_surface_volume_visibility
branch
from
95eb973 to
5dd4ecf
Compare
jeffamstutz
force-pushed
the
helide_surface_volume_visibility
branch
from
5dd4ecf to
6a8b199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.