Revise mkversion invocation #1085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an untested rewrite of the line invoking
mkversionon Windows, based on past vcpkg experience. (The current port version 4.4.2 doesn't invoke mkversion.)The original
"\"...\" ...."fails for some configurations.It is a single CMake list item, with embedded quotes which go into a build system rule which may or may not get the inner quotes correctly for the actual invocation of the command.
The rule of thumb is:
There is only outer quotes for items in a cmake list.
There are different generators for different build systems.
With ninja build files, commands may be executed via a shell or directly, depending on the system.
With any type of inner quotes, portability will be limited.
The new line is a CMake list of command and items, with quoting for CMake when items can expand with special characters inside.
(Now this newest version contains an embedded CMake variable
${MKV_VERSION_OPT}which I didn't quote because I assume it is of list type, i.e. potentially expanding to multiple command line arguments.)