Add lock around transcoder initialization #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For std::barrier and std::format.
Update for c++20 so can use std:barrier.
To be revisited later.
"bitwise operation between different enumeration types".
to prevent this system include from appearing in target's INCLUDE_DIRECTORIES property and being added as non-system include to dependent target.
since warning still appeared with include dir in system includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087.
Add threadtests - though unsure how useful they are.
Update all libktx tests for c++20 as new tests need it for std::barrier.
Fixes basisu_c_binding build when ktx_read target is not included in build.
Big thanks to @vmwalker for reporting the problem and providing the fix.