Added test to verify negative result of clSetKernelArg with CL_INVALID_DEVICE_QUEUE #2462
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
12 tasks
bashbaug
reviewed
Dec 10, 2025
Contributor
Author
|
close/open to retrigger CI/CD |
bashbaug
reviewed
Dec 15, 2025
Comment on lines
787
to
794
| // Setup the test | ||
| error = create_single_kernel_helper(context, &program, nullptr, 1, | ||
| &sample_queue_test_kernel, "queue_test", | ||
| build_opts.c_str()); | ||
| test_error(error, "Unable to build test program"); | ||
|
|
||
| queue_arg_kernel = clCreateKernel(program, "queue_test", &error); | ||
| test_error(error, "Unable to get queue_test kernel for built program"); |
Contributor
There was a problem hiding this comment.
This doesn't work - we either need the kernel name to be nullptr, or the kernel handle must not be nullptr.
Since I can't think of a reason not to do so, I'd recommend just using the harness to create the kernel also, and pass a non-nullptr kernel handle.
Suggested change
| // Setup the test | |
| error = create_single_kernel_helper(context, &program, nullptr, 1, | |
| &sample_queue_test_kernel, "queue_test", | |
| build_opts.c_str()); | |
| test_error(error, "Unable to build test program"); | |
| queue_arg_kernel = clCreateKernel(program, "queue_test", &error); | |
| test_error(error, "Unable to get queue_test kernel for built program"); | |
| // Setup the test | |
| error = create_single_kernel_helper(context, &program, &queue_arg_kernel, 1, | |
| &sample_queue_test_kernel, "queue_test", | |
| build_opts.c_str()); | |
| test_error(error, "Unable to create test kernel"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2282, according to work plan from here