Fix archive-sdk when running on wsl#517
Merged
rpavlik merged 1 commit intoKhronosGroup:mainfrom Jan 10, 2025
Merged
Conversation
Contributor
|
Well that is an interesting failure mode - I assume you're running it on a clone on Windows so it used CRLF EOLs, but bash in WSL isn't stripping those of course. Can we just do the trim in the python script instead? One less process invocation per file, etc. |
Contributor
Author
|
Thanks - I did originally test just having the strip in python, but there's also places in the script that need the stripped name too, i.e. in add_to_tar when adding the files. Otherwise, it fails with Happy to make changes if you have any ideas, let me know. |
Contributor
|
Ah, OK, that makes sense then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run
maintainer-scripts/archive-sdk.shon wsl, it failed to build the headers withNo generator options for unknown target: openxr.h. This seemed to be because there was an extra character at the end of the filename, so failed to find the key ingenOpts.This removes the whitespace at the end of the strings before passing it to
genxr.pyto get it working.