Update SPV_AMDX_shader_enqueue#452
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Oct 9, 2024
Merged
Conversation
Co-authored-by: Dan Brown <daniel.brown@amd.com> Co-authored-by: Maciej Jesionowski <maciej.jesionowski@amd.com>
Naghasan
approved these changes
Oct 9, 2024
Naghasan
left a comment
Naghasan
left a comment
There was a problem hiding this comment.
LGTM, there is 2 small discrepancy between the text and grammar but I suspect it is the text being out of sync
Contributor
Yep, now fixed in the spec. Thanks! |
Contributor
|
Merging as discussed in the October 9th teleconference. |
|
Is there a corresponding PR for https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/main/layers/vulkan/generated/spirv_grammar_helper.cpp#L720? |
|
Looks like this is being worked on in KhronosGroup/Vulkan-ValidationLayers#8679 |
jkwak-work
reviewed
Jan 9, 2025
| }, | ||
| { | ||
| "opname" : "OpTypeNodePayloadArrayAMDX", | ||
| "class" : "Reserved", |
There was a problem hiding this comment.
Shouldn't this be type-declaration?
"class" : "Type-Declaration",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers modifications for the SPIR-V change: KhronosGroup/SPIRV-Registry#286