Correctly report unsupported intrinsic

The translator would report the name of the destination variable of an
intrinsic call, which is not very helpful to a user.

Report the offending intrinsic name, and update and unXFAIL a test to
check the error message.  For the test, we need to run `not` with
`--crash`, as the translator currently asserts on errors and we need
to ignore crashes to be able to FileCheck the stderr output.

Author: svenvh

lib/SPIRV/SPIRVWriter.cpp

@@ -1197,7 +1197,8 @@ SPIRVValue *LLVMToSPIRV::transIntrinsicInst(IntrinsicInst *II,
     // LLVM intrinsic functions shouldn't get to SPIRV, because they
     // would have no definition there.
     BM->getErrorLog().checkError(false, SPIRVEC_InvalidFunctionCall,
-                                 II->getName().str(), "", __FILE__, __LINE__);
+                                 II->getCalledValue()->getName().str(), "",
+                                 __FILE__, __LINE__);
   }
   return nullptr;
 }

test/lit.cfg.py

@@ -47,7 +47,7 @@
 
 tool_dirs = [config.llvm_tools_dir, config.llvm_spirv_dir]
 
-tools = ['llc', 'llvm-as', 'llvm-dis', 'llvm-dwarfdump', 'llvm-objdump', 'llvm-readelf', 'llvm-readobj',  'llvm-spirv']
+tools = ['llc', 'llvm-as', 'llvm-dis', 'llvm-dwarfdump', 'llvm-objdump', 'llvm-readelf', 'llvm-readobj',  'llvm-spirv', 'not']
 
 llvm_config.add_tool_substitutions(tools, tool_dirs)
 

test/llvm.fma.ll

@@ -1,9 +1,10 @@
 ; Translator should not translate llvm intrinsic calls straight forward.
-; It either represnts intrinsic's semantics with SPIRV instruction(s), or
+; It either represents intrinsic's semantics with SPIRV instruction(s), or
 ; reports an error.
-; XFAIL: *
 ; RUN: llvm-as %s -o %t.bc
-; RUN: llvm-spirv %t.bc
+; RUN: not --crash llvm-spirv %t.bc 2>&1 | FileCheck %s
+
+; CHECK: InvalidFunctionCall: Unexpected llvm intrinsic: llvm.fma.f32
 
 target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
 target triple = "spir64"