[Backport to llvm_release_180] Fix globals' type deduction in TypeScavenger#3613
Merged
vmaksimo merged 1 commit intollvm_release_180from Mar 9, 2026
Merged
Conversation
If a global is initialized with a ConstantExpr returning a pointer (getelementptr), the right type has to be deduced instead of defaulting it to i8*.
|
|
Contributor
|
@mshelego please take a look, thanks |
mshelego
approved these changes
Mar 9, 2026
Contributor
|
Reopening to trigger CLA/CI |
Contributor
|
@mshelego it looks like the CLA check fails. Could you please check if you have signed it? See the second comment. |
vmaksimo
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2431 into
llvm_release_180.All commits applied cleanly.